This repository has been archived by the owner on Aug 17, 2019. It is now read-only.
Installer refactor + getPrefix() #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
mikesherov
approved these changes
Sep 2, 2017
| } | ||
| } | ||
|
|
||
| module.exports._fileExists = fileExists |
There was a problem hiding this comment.
Is there a reason to export this?
| }) | ||
| } | ||
|
|
||
| module.exports._isRootPath = isRootPath |
There was a problem hiding this comment.
Same question as above.
rmg
reviewed
Sep 2, 2017
bin/cli.js
Outdated
| main(parseArgs()).then((details) => { | ||
| console.log(`added ${details.count} packages in ${ | ||
| details.time / 1000 | ||
| new Installer(parseArgs()).then(details => { |
There was a problem hiding this comment.
Should this be .run().then(...)? Does this mean the tests don't currently exercise the CLI portion?
There was a problem hiding this comment.
oh yeah. I fixed this in a different branch. Fix't
|
Shucks, I wish I knew about tacks before making my own, essentially. Looks good! |
mikesherov
approved these changes
Sep 2, 2017
| console.log(`added ${details.count} packages in ${ | ||
| details.time / 1000 | ||
| new Installer(parseArgs()).run().then(details => { | ||
| console.error(`added ${details.pkgCount} packages in ${ |
There was a problem hiding this comment.
Just writing it to stderr because it's not really meant as user data. Just informative side-stuff.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rewrites the toplevel installer such that it uses object+method style instead of a bunch of toplevel functions. This is mainly useful so we can keep installer state over time: for example, I plan on using this to keep a "logical tree" around that I can use so scripts run in their logical dependency order.
As a bonus, this also pulls in
get-prefixso we calculate the installer prefix using the same logic as npm.