Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bitvec #73

Merged
merged 4 commits into from
May 4, 2022
Merged

Upgrade bitvec #73

merged 4 commits into from
May 4, 2022

Conversation

koivunej
Copy link
Contributor

Fixes #70. Upgrades MSRV from 1.51 to 1.56, matching bitvec's, upgrades bitvec to "1".

Follow-up to #72, which is hopefully merged and a patch version released first. There shouldn't be any major conflicts, but the workflow will need to be fixed for the nightly doc lint job's rust version (#72 changed it to 1.51, needs to be 1.56 now) .. ended up doing that in this branch as well, latest nightly rustdoc has some issues.

@dignifiedquire
Copy link
Contributor

Any chance this could be merged? I have a lot of duplicates of bitvec in my dependency tree due to this currently.

Copy link
Member

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, looks exactly like what I'd planned to do 😄

@str4d
Copy link
Member

str4d commented Apr 26, 2022

Merging this will commit the main branch to an 0.12 release, so I'm going to hold off merging this until we're definitely on that train. If @koivunej can fix #72 before then, we can perhaps get a point release out with that.

@koivunej
Copy link
Contributor Author

If koivunej can fix #72 before then, we can perhaps get a point release out with that.

This would sound excellent and help anyone trying to use the ff as different bitvec versions are still being depended on in the wild.

@ebfull ebfull merged commit 6e92161 into zkcrypto:main May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bitvec v1.0
4 participants