Reduce allocations in group::Wnaf
#33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a scalar with a 32-byte representation, this reduces the number of allocations in `Wnaf::new().scalar(..).base(..)` from 9 to 3. The amortized allocation cost (for a reused `Wnaf::new()`) remains at 1.
daira
approved these changes
Sep 7, 2022
There was a problem hiding this comment.
utACK.
I notice that there is no public API to do the precomputations for the scalar and for the base separately. There should be no obstacle to allowing that because the precomputations are independent. That would be precisely what we need to avoid excess computation and allocation when doing scalar muls for the cross product of a set of scalars and a set of bases. (See zcash/librustzcash#593.)
Filed as #34.
This also removes the `byteorder` dependency, as we can depend solely on APIs available in our MSRV.
daira
reviewed
Sep 8, 2022
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.