no_std support #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
str4d
reviewed
Aug 26, 2020
tarcieri
added a commit
to RustCrypto/traits
that referenced
this pull request
Sep 3, 2020
Vendors the core set of group traits from the `group` crate: https://github.com/zkcrypto/group Using the upstream crate is presently blocked on `no_std` support: zkcrypto/group#9 However, aside from a suggested change to the RNG API (zkcrypto/group#10) the traits used in this PR are verbatim from the upstream crate, so migrating to it should be easy. This PR also removes the `rand` and `weierstrass` features from the `elliptic-curve` crate, making `rand_core` a hard requirement, since it seems at least `rand_core` will probably be a hard requirement for `group`, and requiring an RNG as a hard dependency makes sense.
tarcieri
added a commit
to RustCrypto/traits
that referenced
this pull request
Sep 3, 2020
Vendors the core set of group traits from the `group` crate: https://github.com/zkcrypto/group Using the upstream crate is presently blocked on `no_std` support: zkcrypto/group#9 However, aside from a suggested change to the RNG API (zkcrypto/group#10) the traits used in this PR are verbatim from the upstream crate, so migrating to it should be easy. This PR also removes the `rand` and `weierstrass` features from the `elliptic-curve` crate, making `rand_core` a hard requirement, since it seems at least `rand_core` will probably be a hard requirement for `group`, and requiring an RNG as a hard dependency makes sense.
tarcieri
added a commit
to RustCrypto/traits
that referenced
this pull request
Sep 3, 2020
Vendors the core set of group traits from the `group` crate: https://github.com/zkcrypto/group Using the upstream crate is presently blocked on `no_std` support: zkcrypto/group#9 However, aside from a suggested change to the RNG API (zkcrypto/group#10) the traits used in this PR are verbatim from the upstream crate, so migrating to it should be easy. This PR also removes the `rand` and `weierstrass` features from the `elliptic-curve` crate, making `rand_core` a hard requirement, since it seems at least `rand_core` will probably be a hard requirement for `group`, and requiring an RNG as a hard dependency makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.