Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: modular layers #13

Merged
merged 13 commits into from
Sep 16, 2022
Merged

refactor: modular layers #13

merged 13 commits into from
Sep 16, 2022

Conversation

alexander-camuto
Copy link
Collaborator

@alexander-camuto alexander-camuto commented Sep 14, 2022 •
edited
Loading

  • Simplified layer interfaces whereby both Affine and Conv layers now ingest "Kernels" which can have fixed or advice parameters.
  • Both Affine and Conv layers use the same "Input/Output" layer types (rather than a split between input and image).
  • Inputs, Outputs and Parameters use the same IOConfig to assign and layout

@alexander-camuto alexander-camuto marked this pull request as draft September 14, 2022 22:44
@alexander-camuto
Copy link
Collaborator Author

alexander-camuto commented Sep 14, 2022 •
edited
Loading

TODO: add bias back in to affine layers (completed by f013111)

@alexander-camuto alexander-camuto marked this pull request as ready for review September 16, 2022 08:46
@jasonmorton jasonmorton merged commit 3a57438 into main Sep 16, 2022
@alexander-camuto alexander-camuto mentioned this pull request Sep 16, 2022
Closed
@alexander-camuto alexander-camuto deleted the ac/layers branch September 17, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonmorton jasonmorton Awaiting requested review from jasonmorton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexander-camuto @jasonmorton