-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mobile support #361
Merged
Merged
add mobile support #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I started this a while ago and thought about transitioning the TopNav to a BottomNav at a certain breakpoint. Is that something you can incorporate? |
This reverts commit 7f1b355.
0xSachinK
force-pushed
the
bert0rm/add_mobile
branch
from
May 4, 2024 08:37
b8d989d
to
18814cd
Compare
asoong
pushed a commit
that referenced
this pull request
May 9, 2024
* add mobile support * address feedback * fix issue with dropdown * nit * address feedback * try to remove upload email * rm icon from current order * rm icon from orders * use column on mobile devices for intent rows * fix color in bg * row to col * center * revert * center pt2 * Revert "try to remove upload email" This reverts commit 7f1b355. * rm email upload on mobile * fix padding * Increase font size on liquidity page --------- Co-authored-by: 0xSachinK <0xsachink@gmail.com>
asoong
pushed a commit
that referenced
this pull request
May 9, 2024
* add mobile support * address feedback * fix issue with dropdown * nit * address feedback * try to remove upload email * rm icon from current order * rm icon from orders * use column on mobile devices for intent rows * fix color in bg * row to col * center * revert * center pt2 * Revert "try to remove upload email" This reverts commit 7f1b355. * rm email upload on mobile * fix padding * Increase font size on liquidity page --------- Co-authored-by: 0xSachinK <0xsachink@gmail.com>
asoong
pushed a commit
that referenced
this pull request
May 9, 2024
* add mobile support * address feedback * fix issue with dropdown * nit * address feedback * try to remove upload email * rm icon from current order * rm icon from orders * use column on mobile devices for intent rows * fix color in bg * row to col * center * revert * center pt2 * Revert "try to remove upload email" This reverts commit 7f1b355. * rm email upload on mobile * fix padding * Increase font size on liquidity page --------- Co-authored-by: 0xSachinK <0xsachink@gmail.com>
asoong
pushed a commit
that referenced
this pull request
May 9, 2024
* add mobile support * address feedback * fix issue with dropdown * nit * address feedback * try to remove upload email * rm icon from current order * rm icon from orders * use column on mobile devices for intent rows * fix color in bg * row to col * center * revert * center pt2 * Revert "try to remove upload email" This reverts commit 7f1b355. * rm email upload on mobile * fix padding * Increase font size on liquidity page --------- Co-authored-by: 0xSachinK <0xsachink@gmail.com>
asoong
pushed a commit
that referenced
this pull request
May 9, 2024
* add mobile support * address feedback * fix issue with dropdown * nit * address feedback * try to remove upload email * rm icon from current order * rm icon from orders * use column on mobile devices for intent rows * fix color in bg * row to col * center * revert * center pt2 * Revert "try to remove upload email" This reverts commit 7f1b355. * rm email upload on mobile * fix padding * Increase font size on liquidity page --------- Co-authored-by: 0xSachinK <0xsachink@gmail.com>
asoong
pushed a commit
that referenced
this pull request
May 9, 2024
* add mobile support * address feedback * fix issue with dropdown * nit * address feedback * try to remove upload email * rm icon from current order * rm icon from orders * use column on mobile devices for intent rows * fix color in bg * row to col * center * revert * center pt2 * Revert "try to remove upload email" This reverts commit 7f1b355. * rm email upload on mobile * fix padding * Increase font size on liquidity page --------- Co-authored-by: 0xSachinK <0xsachink@gmail.com>
asoong
pushed a commit
that referenced
this pull request
May 9, 2024
* add mobile support * address feedback * fix issue with dropdown * nit * address feedback * try to remove upload email * rm icon from current order * rm icon from orders * use column on mobile devices for intent rows * fix color in bg * row to col * center * revert * center pt2 * Revert "try to remove upload email" This reverts commit 7f1b355. * rm email upload on mobile * fix padding * Increase font size on liquidity page --------- Co-authored-by: 0xSachinK <0xsachink@gmail.com>
asoong
pushed a commit
that referenced
this pull request
May 9, 2024
* add mobile support * address feedback * fix issue with dropdown * nit * address feedback * try to remove upload email * rm icon from current order * rm icon from orders * use column on mobile devices for intent rows * fix color in bg * row to col * center * revert * center pt2 * Revert "try to remove upload email" This reverts commit 7f1b355. * rm email upload on mobile * fix padding * Increase font size on liquidity page --------- Co-authored-by: 0xSachinK <0xsachink@gmail.com>
asoong
pushed a commit
that referenced
this pull request
May 27, 2024
* add mobile support * address feedback * fix issue with dropdown * nit * address feedback * try to remove upload email * rm icon from current order * rm icon from orders * use column on mobile devices for intent rows * fix color in bg * row to col * center * revert * center pt2 * Revert "try to remove upload email" This reverts commit 7f1b355. * rm email upload on mobile * fix padding * Increase font size on liquidity page --------- Co-authored-by: 0xSachinK <0xsachink@gmail.com>
asoong
pushed a commit
that referenced
this pull request
Jun 3, 2024
* add mobile support * address feedback * fix issue with dropdown * nit * address feedback * try to remove upload email * rm icon from current order * rm icon from orders * use column on mobile devices for intent rows * fix color in bg * row to col * center * revert * center pt2 * Revert "try to remove upload email" This reverts commit 7f1b355. * rm email upload on mobile * fix padding * Increase font size on liquidity page --------- Co-authored-by: 0xSachinK <0xsachink@gmail.com>
asoong
pushed a commit
that referenced
this pull request
Jun 5, 2024
* add mobile support * address feedback * fix issue with dropdown * nit * address feedback * try to remove upload email * rm icon from current order * rm icon from orders * use column on mobile devices for intent rows * fix color in bg * row to col * center * revert * center pt2 * Revert "try to remove upload email" This reverts commit 7f1b355. * rm email upload on mobile * fix padding * Increase font size on liquidity page --------- Co-authored-by: 0xSachinK <0xsachink@gmail.com>
asoong
added a commit
that referenced
this pull request
Jun 11, 2024
* add mobile support (#361) * add mobile support * address feedback * fix issue with dropdown * nit * address feedback * try to remove upload email * rm icon from current order * rm icon from orders * use column on mobile devices for intent rows * fix color in bg * row to col * center * revert * center pt2 * Revert "try to remove upload email" This reverts commit 7f1b355. * rm email upload on mobile * fix padding * Increase font size on liquidity page --------- Co-authored-by: 0xSachinK <0xsachink@gmail.com> * Revert yarn.lock changes * Fix warnings * Replace QR with link on mobile (#365) * Add button instead of qr on mobile * Update button color when payment sent * Update requirement step three to be more clear * Remove unused css * Fix link * Fix bg color when on desktop * simplify requirement text * Add suggested changes * Rebase develop --------- Co-authored-by: Alex Soong <alexsoong91@gmail.com> * Update Privacy Policy and ToS margin * Create BottomBar for Mobile Experience (#382) * Add basic BottomNav component * Minor edits to TopNav * Add bottom bar to App and Terms of Service and PP * Update AccountDropown to properly display items based on media query * Add space for bottom bar to ever major page * Fix warnings * Expand width on AccountDropdown * Show full email if available in connect button * Reduce width of nav bar dropdown * Fix Swap and Send inputs resizing and flex direction * Update padding for all pages * Polish touches * Fix warnings * Size the preview Swap modal larger * Revert yarn.lock * Move Deposit into NavDropdown * Update top padding on connect button * Fix border radius and border on OffRamperIntentTable and OnRamperIntentTable * Adjust z-index of Bottom nav * Fix route to deposits * Update to correct z index for bottom navbar * Increase the min width size for cutoff to 600 px * Fix landing page scroll * Lock width of TextTransition to prevent width adjustin * Fix padding on Landing and SwapPreview * Create new SwapModalMobile component for mobile on ramp completion * Move table headers to correct locations on mobile screens * Fix size on Swap and Send page headers * Fix background color and add new icon for PWA * Update verison number * Refetch USDC balance on successful deposit created * Bump icon * Remove emoji * Test manifest.json * Set zIndex properly * PlatformRow currency label wraps * Experiment with setting width for SwapPreview * Update verison * Try static directory for app icon * Constrain width on mobile landing page * Update static asset route * Set mobile landing width to auto * Edit apple-touch-icon in index.html * Bump Apple icon * Try fixed width on Hero container * Larger app icon * Update app to 0.4.2 * Fix path to apple icon * Update Liquidity column header and row font size * Bump logo positioning in app icon --------- Co-authored-by: Rigo <33237379+bert0RM@users.noreply.github.com> Co-authored-by: 0xSachinK <0xsachink@gmail.com>
Based merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding mobile support by making the pages responsive
Screen capture
Screen.Recording.2024-04-29.at.2.24.50.PM.1.mov