-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record page (view contribution) #66
Conversation
updates layout, enables search/filtering, implements pagination
spelling of component to "Row"
Shown on /record page
This is awesome! Thanks @wackerow. Regarding the data, you could try to run the sequencer to run some contributions and get the transcript.json file. To run the sequencer you can: Sequencer
export GH_CLIENT_SECRET=XXXXXXXXXXXXXXXXXXXXXXXXXXX This is for testing/development onlyexport ETH_MIN_NONCE=0 Frontend
The sequencer would use port 3000 and the frontend would use port 3001. |
@NicoSerranoP Don't have access to Ubuntu at the moment myself. Any reason I would need to set all that up for this PR? Is there a way we can tap into the existing dev sequencer to test pulling the data into the front-end? |
@wackerow I just created a The participants ids are
Would it be a good idea to implement a function that checks the signature and guarantee that the contribution is coming from that participant? The search function would only look that the participantsIds but the sequencer could been sending wrong data. Do you think people would trust our implemented function or we just let them download the file and perform the verification by themselves (with their own built tools) |
@NicoSerranoP That's a great question... Do you mean just checking the signature of the active user, or checking the validity of every contribution before displaying? My concern on the later would just be performance... if we end up having to verify thousands of signatures before rendering the page. |
I was thinking only validating the signature of the searched contribution. If I type I am thinking that maybe people that care about it might want to do the checking themselves and not trust any other party tool. |
Description
/record
page/record
Screenshots
Related issue
* Still using dummy data; still need to pull actual contributions