-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: noname cli: read input/output JSON from file #110
Conversation
…nd private_inputs_str
…son, if can not we will try parse as file path
…inputs and private_inputs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great, thanks! The only problem that I see is that we're not making use of the examples/json/* files right? Maybe we should have a test to exercise that path?
Oh i understand you , i only tested the inputs manually by writing commands to the paths to the files, i didn't write actual tests , i'm just seeing a test folder in the repo just now, i can do that. |
we ended up merging this one: #111 but if you want to add your comments to the CLI usage that would still be great! |
Will do ! |
I'll close this one for now! |
Closes #92
There's a lot of changes - i'll briefly summarize what i did
Here are some example commands to test the new changes to the cli
cargo run test --backend r1cs-bn254 --path examples/arithmetic.no --private-inputs '{"private_input": "2"}' --public-inputs '{"public_input": "2"}' --debug
cargo run test --backend r1cs-bn254 --path examples/arithmetic.no --private-inputs examples/json/inputs1/private_input.json --public-inputs examples/json/inputs1/public_input.json --debug