Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for clone overlap #276

Merged
merged 7 commits into from
Jun 15, 2023
Merged

Update docs for clone overlap #276

merged 7 commits into from
Jun 15, 2023

Conversation

zktuong
Copy link
Owner

@zktuong zktuong commented Jun 15, 2023

  • now colorby is optional. Default will always match groupby.
  • added clarity to the docstring on how to use colorby to color sub-categories.
  • remove unnecessary arguments in tl.clone_overlap and pl.clone_overlap.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #276 (ef62b54) into master (8a50b91) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #276   +/-   ##
=======================================
  Coverage   82.24%   82.24%           
=======================================
  Files          47       47           
  Lines        9064     9064           
=======================================
  Hits         7455     7455           
  Misses       1609     1609           
Flag Coverage Δ
unittests 82.24% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandelion/tools/_tools.py 86.07% <ø> (ø)
dandelion/plotting/_plotting.py 82.78% <100.00%> (ø)
tests/test_mouse_plotting.py 100.00% <100.00%> (ø)

@zktuong zktuong merged commit f3fdf6b into master Jun 15, 2023
@zktuong zktuong deleted the fix-docs-for-clone-overlap branch June 15, 2023 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant