Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disregard non productive contigs when reporting chain/locus status #366

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

zktuong
Copy link
Owner

@zktuong zktuong commented Mar 28, 2024

@suochenqu requested to change the locus/chain status to mainly reflect only productive contigs.

This is now the default behaviour, but can be toggled with report_status_productive=True or report_status_productive=False with ddl.Dandelion.

for some context:
image
there are extra contigs in the J only TRA and TRB
there's no term at the moment for describing this combination other that extra pair and it's not technically a single pair either
it's orphan VDJ if we consider only productive contigs.

chain_status depends on locus_status -> which currently says Extra VDJ + TRA -> this only checks at the locus column for how many TRB and TRA contigs there are. if chain_status detects the word Extra (and in this case there are 2 TRB VDJ contigs, hence extra VDJ), it will then just simply flag this as an Extra pair

@zktuong
Copy link
Owner Author

zktuong commented Mar 28, 2024

isotype status is still being reflected as Multi - so still need some more fixes.

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.75%. Comparing base (6998cc6) to head (5147c22).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
+ Coverage   83.73%   83.75%   +0.01%     
==========================================
  Files          52       52              
  Lines        9070     9080      +10     
==========================================
+ Hits         7595     7605      +10     
  Misses       1475     1475              
Flag Coverage Δ
unittests 83.75% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
dandelion/utilities/_core.py 87.81% <100.00%> (+0.03%) ⬆️
dandelion/utilities/_utilities.py 83.80% <100.00%> (+0.16%) ⬆️
tests/test_io.py 100.00% <100.00%> (ø)

@zktuong zktuong merged commit bb36978 into master Apr 1, 2024
15 checks passed
@zktuong zktuong deleted the adjust-chain-status-to-only-consider-productive branch April 1, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant