disregard non productive contigs when reporting chain/locus status #366
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@suochenqu requested to change the locus/chain status to mainly reflect only productive contigs.
This is now the default behaviour, but can be toggled with
report_status_productive=True
orreport_status_productive=False
withddl.Dandelion
.for some context:
there are extra contigs in the J only TRA and TRB
there's no term at the moment for describing this combination other that extra pair and it's not technically a single pair either
it's orphan VDJ if we consider only productive contigs.
chain_status depends on locus_status -> which currently says Extra VDJ + TRA -> this only checks at the locus column for how many TRB and TRA contigs there are. if chain_status detects the word Extra (and in this case there are 2 TRB VDJ contigs, hence extra VDJ), it will then just simply flag this as an Extra pair