Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements for code coverage #1026

Merged
merged 5 commits into from
Sep 22, 2021
Merged

Improvements for code coverage #1026

merged 5 commits into from
Sep 22, 2021

Conversation

nmoinvaz
Copy link
Member

Testing code coverage improvement.

@codecov
Copy link

codecov bot commented Jul 11, 2021 •
edited
Loading

Codecov Report

Merging #1026 (304aa54) into develop (12a975a) will increase coverage by 1.27%.
The diff coverage is 13.33%.

❗ Current head 304aa54 differs from pull request most recent head 4d3d809. Consider uploading reports for the commit 4d3d809 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1026      +/-   ##
===========================================
+ Coverage    77.91%   79.18%   +1.27%     
===========================================
  Files           81       81              
  Lines         8389     8374      -15     
  Branches      1371     1363       -8     
===========================================
+ Hits          6536     6631      +95     
+ Misses        1320     1200     -120     
- Partials       533      543      +10
Flag Coverage Δ
macos_clang 69.03% <11.53%> (+0.98%) ⬆️
macos_gcc 67.85% <10.00%> (+1.10%) ⬆️
ubuntu_clang 72.85% <11.53%> (+1.02%) ⬆️
ubuntu_clang_debug 73.14% <10.78%> (+0.95%) ⬆️
ubuntu_clang_inflate_allow_invalid_dist 72.61% <11.53%> (+1.02%) ⬆️
ubuntu_clang_inflate_strict 72.84% <11.53%> (+1.02%) ⬆️
ubuntu_clang_mmap 72.83% <11.53%> (+1.02%) ⬆️
ubuntu_clang_msan 72.85% <11.53%> (+1.02%) ⬆️
ubuntu_clang_pigz 31.69% <ø> (ø)
ubuntu_clang_pigz_no_optim 37.83% <ø> (ø)
ubuntu_clang_pigz_no_threads 31.34% <ø> (ø)
ubuntu_clang_reduced_mem 73.11% <11.53%> (+1.02%) ⬆️
ubuntu_gcc 72.21% <10.10%> (+1.11%) ⬆️
ubuntu_gcc_aarch64 75.67% <10.10%> (+1.18%) ⬆️
ubuntu_gcc_aarch64_compat_no_opt 73.44% <10.84%> (+1.22%) ⬆️
ubuntu_gcc_aarch64_no_acle 74.97% <10.00%> (+1.22%) ⬆️
ubuntu_gcc_aarch64_no_neon 75.26% <10.00%> (+1.23%) ⬆️
ubuntu_gcc_armhf 75.67% <10.10%> (+1.19%) ⬆️
ubuntu_gcc_armhf_compat_no_opt 73.40% <10.84%> (+1.23%) ⬆️
ubuntu_gcc_armhf_no_acle 75.93% <10.10%> (+1.20%) ⬆️
ubuntu_gcc_armhf_no_neon 76.19% <10.10%> (+1.21%) ⬆️
ubuntu_gcc_armsf 75.68% <10.10%> (+1.19%) ⬆️
ubuntu_gcc_armsf_compat_no_opt 73.40% <10.84%> (+1.23%) ⬆️
ubuntu_gcc_compat_no_opt 74.53% <10.86%> (+1.19%) ⬆️
ubuntu_gcc_mingw_i686 0.00% <0.00%> (ø)
ubuntu_gcc_mingw_x86_64 0.00% <0.00%> (ø)
ubuntu_gcc_no_avx2 75.78% <10.00%> (+1.16%) ⬆️
ubuntu_gcc_no_ctz 76.53% <9.27%> (?)
ubuntu_gcc_no_ctzll 76.22% <9.27%> (?)
ubuntu_gcc_no_pclmulqdq 70.62% <10.00%> (+1.15%) ⬆️
ubuntu_gcc_no_sse2 73.23% <10.00%> (+1.13%) ⬆️
ubuntu_gcc_no_sse4 72.61% <10.00%> (+1.17%) ⬆️
ubuntu_gcc_o3 73.07% <9.27%> (+1.16%) ⬆️
ubuntu_gcc_osb 75.13% <12.76%> (+1.04%) ⬆️
ubuntu_gcc_pigz 31.68% <ø> (-0.03%) ⬇️
ubuntu_gcc_pigz_aarch64 35.87% <ø> (+0.03%) ⬆️
ubuntu_gcc_ppc 74.36% <9.27%> (+1.22%) ⬆️
ubuntu_gcc_ppc64 76.96% <9.27%> (+1.23%) ⬆️
ubuntu_gcc_ppc64le 75.55% <9.27%> (+1.23%) ⬆️
ubuntu_gcc_s390x 74.94% <9.18%> (+1.13%) ⬆️
ubuntu_gcc_sparc64 77.40% <9.27%> (+1.25%) ⬆️
win64_gcc 70.67% <9.27%> (+1.12%) ⬆️
win64_gcc_compat_no_opt 74.83% <10.00%> (+1.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/example.c 81.71% <13.33%> (+4.56%) ⬆️
trees.c 96.44% <0.00%> (+0.27%) ⬆️
functable.c 76.07% <0.00%> (+0.44%) ⬆️
inflate.c 88.50% <0.00%> (+0.94%) ⬆️
deflate.c 73.48% <0.00%> (+5.08%) ⬆️
compare258.c 88.65% <0.00%> (+33.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12a975a...4d3d809. Read the comment docs.

@nmoinvaz nmoinvaz force-pushed the ci/compare-258-code-coverage branch from efd7000 to 14d7bee Compare July 11, 2021 21:33
mtl1979
mtl1979 reviewed Jul 11, 2021
View reviewed changes
test/example.c Outdated
err = PREFIX(deflateSetHeader)(&c_stream, head);
CHECK_ERR(err, "deflateSetHeader");
if (err == Z_OK) {
printf("deflateSetHeader(): OK\n");
}
PREFIX(deflateBound)(&c_stream, comprLen);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does nothing... It gets optimized away...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure? Its getting covered by code coverage..

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the return value is ignored, it gets optimized away.

@nmoinvaz nmoinvaz changed the title Added CI instances for CTZLL and CTZ builtin existence Improvements for code coverage Jul 11, 2021
@nmoinvaz nmoinvaz force-pushed the ci/compare-258-code-coverage branch from 0ba0f66 to c69fee4 Compare July 12, 2021 00:21
@nmoinvaz nmoinvaz force-pushed the ci/compare-258-code-coverage branch from c69fee4 to 4813c78 Compare July 12, 2021 00:23
@nmoinvaz nmoinvaz force-pushed the ci/compare-258-code-coverage branch from 304aa54 to 4d3d809 Compare July 12, 2021 03:38
@nmoinvaz nmoinvaz added cleanup Improving maintainability or removing code. Continuous Integration labels Aug 26, 2021
@nmoinvaz nmoinvaz marked this pull request as ready for review September 4, 2021 19:39
@Dead2 Dead2 merged commit 92107a9 into zlib-ng:develop Sep 22, 2021
Dead2 added a commit that referenced this pull request Dec 13, 2021
@Dead2
Version 2.0.6
2cf68ab 
 - Fix hangs on macOS #1031
 - Fix minideflate write buffers being overwritten #1060
 - Fix build problems when building outside of source dir #1049
 - Fix build problems on arm2-7 #1030
 - Fixed some compile warnings #1020 #1036 #1037 #1048
 - Improved posix memalign support #888
 - Improvements to testing #637 #1026 #1035 #1051 #1056 #1063 #1067
 - Improvements for integration into other projects #1022 #1042
 - Code style fixes #637 #1040 #1050
@Dead2 Dead2 mentioned this pull request Dec 13, 2021
Merged
Dead2 added a commit that referenced this pull request Dec 20, 2021
@Dead2
Version 2.0.6
4c43f09 
 - Fix hangs on macOS #1031
 - Fix minideflate write buffers being overwritten #1060
 - Fix deflateBound and compressBound returning too small size estimates #1071
 - Fix build problems when building outside of source dir #1049
 - Fix build problems on arm2-7 #1030
 - Fixed some compile warnings #1020 #1036 #1037 #1048
 - Improved posix memalign support #888
 - Improvements to testing #637 #1026 #1032 #1035 #1051 #1056 #1063 #1067
 - Improvements for integration into other projects #1022 #1042
 - Code style fixes #637 #1040 #1050 #1075
Dead2 added a commit that referenced this pull request Dec 20, 2021
@Dead2
Version 2.0.6
0436e5c 
 - Fix hangs on macOS #1031
 - Fix minideflate write buffers being overwritten #1060
 - Fix deflateBound and compressBound returning too small size estimates #1071
 - Fix build problems when building outside of source dir #1049
 - Fix build problems on arm2-7 #1030
 - Fixed some compile warnings #1020 #1036 #1037 #1048
 - Improved posix memalign support #888
 - Improvements to testing #637 #1026 #1032 #1035 #1051 #1056 #1063 #1067
 - Improvements for integration into other projects #1022 #1042
 - Code style fixes #637 #1040 #1050 #1075
Dead2 added a commit that referenced this pull request Dec 20, 2021
@Dead2
Version 2.0.6
a7d7aea 
 - Fix hangs on macOS #1031
 - Fix minideflate write buffers being overwritten #1060
 - Fix deflateBound and compressBound returning too small size estimates #1071
 - Fix build problems when building outside of source dir #1049
 - Fix build problems on arm2-7 #1030
 - Fixed some compile warnings #1020 #1036 #1037 #1048
 - Improved posix memalign support #888
 - Improvements to testing #637 #1026 #1032 #1035 #1051 #1056 #1063 #1067
 - Improvements for integration into other projects #1022 #1042
 - Code style fixes #637 #1040 #1050 #1075
Dead2 added a commit that referenced this pull request Dec 20, 2021
@Dead2
Version 2.0.6
5618c06 
 - Fix hangs on macOS #1031
 - Fix minideflate write buffers being overwritten #1060
 - Fix deflateBound and compressBound returning too small size estimates #1049 #1071
 - Fix incorrect function declaration warning #1080
 - Fix build problems when building outside of source dir #1049
 - Fix build problems on arm2-7 #1030
 - Fixed some compile warnings #1020 #1036 #1037 #1048
 - Improved posix memalign support #888
 - Improvements to testing #637 #1026 #1032 #1035 #1049 #1051 #1056 #1063 #1067
 - Improvements for integration into other projects #1022 #1042
 - Code style fixes #637 #1040 #1050 #1075
Dead2 added a commit that referenced this pull request Dec 20, 2021
@Dead2
Version 2.0.6
9f99d5b 
 - Fix hangs on macOS #1031
 - Fix minideflate write buffers being overwritten #1060
 - Fix deflateBound and compressBound returning too small size estimates #1049 #1071
 - Fix incorrect function declaration warning #1080
 - Fix build problems when building outside of source dir #1049
 - Fix build problems on arm2-7 #1030
 - Fixed some compile warnings #1020 #1036 #1037 #1048
 - Improved posix memalign support #888
 - Improvements to testing #637 #1026 #1032 #1035 #1049 #1051 #1056 #1063 #1067 #1079
 - Improvements for integration into other projects #1022 #1042
 - Code style fixes #637 #1040 #1050 #1075
Dead2 added a commit that referenced this pull request Dec 24, 2021
@Dead2
Version 2.0.6
b56a2fd 
 - Fix hangs on macOS #1031
 - Fix minideflate write buffers being overwritten #1060
 - Fix deflateBound and compressBound returning too small size estimates #1049 #1071
 - Fix incorrect function declaration warning #1080
 - Fix build problems when building outside of source dir #1049
 - Fix build problems on arm2-7 #1030
 - Fixed some compile warnings #1020 #1036 #1037 #1048
 - Improved posix memalign support #888
 - Improvements to testing #637 #1026 #1032 #1035 #1049 #1051 #1056 #1063 #1067 #1079
 - Improvements for integration into other projects #1022 #1042
 - Code style fixes #637 #1040 #1050 #1075
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtl1979 mtl1979 mtl1979 left review comments

Assignees
No one assigned
Labels
cleanup Improving maintainability or removing code. Continuous Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nmoinvaz @mtl1979 @Dead2