Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed crc32_combine_gen declaration warning in zlib-ng API. #1080

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

nmoinvaz
Copy link
Member

See #1077.

@codecov
Copy link

codecov bot commented Dec 20, 2021

Codecov Report

Merging #1080 (b19c7d1) into develop (70f608c) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1080      +/-   ##
===========================================
- Coverage    81.50%   81.47%   -0.03%     
===========================================
  Files           87       87              
  Lines         8845     8847       +2     
  Branches      1427     1425       -2     
===========================================
- Hits          7209     7208       -1     
- Misses        1079     1081       +2     
- Partials       557      558       +1     
Flag Coverage Δ
macos_clang 69.49% <100.00%> (ø)
macos_gcc 68.02% <100.00%> (ø)
ubuntu_clang 74.26% <100.00%> (ø)
ubuntu_clang_debug 74.42% <100.00%> (ø)
ubuntu_clang_inflate_allow_invalid_dist 74.12% <100.00%> (ø)
ubuntu_clang_inflate_strict 74.17% <100.00%> (ø)
ubuntu_clang_mmap 74.23% <100.00%> (ø)
ubuntu_clang_msan 74.26% <100.00%> (ø)
ubuntu_clang_pigz 35.07% <ø> (ø)
ubuntu_clang_pigz_no_optim 39.57% <ø> (ø)
ubuntu_clang_pigz_no_threads 34.59% <ø> (ø)
ubuntu_clang_reduced_mem 74.40% <100.00%> (ø)
ubuntu_gcc 73.66% <100.00%> (ø)
ubuntu_gcc_aarch64 75.53% <100.00%> (ø)
ubuntu_gcc_aarch64_compat_no_opt 73.23% <100.00%> (ø)
ubuntu_gcc_aarch64_no_acle 74.98% <100.00%> (ø)
ubuntu_gcc_aarch64_no_neon 75.10% <100.00%> (ø)
ubuntu_gcc_armhf 75.52% <100.00%> (ø)
ubuntu_gcc_armhf_compat_no_opt 73.19% <100.00%> (ø)
ubuntu_gcc_armhf_no_acle 75.78% <100.00%> (ø)
ubuntu_gcc_armhf_no_neon 75.87% <100.00%> (ø)
ubuntu_gcc_armsf 75.53% <100.00%> (ø)
ubuntu_gcc_armsf_compat_no_opt 73.19% <100.00%> (ø)
ubuntu_gcc_compat_no_opt 74.18% <100.00%> (ø)
ubuntu_gcc_compat_sprefix 73.56% <100.00%> (ø)
ubuntu_gcc_mingw_i686 0.00% <0.00%> (ø)
ubuntu_gcc_mingw_x86_64 0.00% <0.00%> (ø)
ubuntu_gcc_no_avx2 75.71% <100.00%> (ø)
ubuntu_gcc_no_ctz 76.22% <100.00%> (ø)
ubuntu_gcc_no_ctzll 75.90% <100.00%> (ø)
ubuntu_gcc_no_pclmulqdq 72.34% <100.00%> (ø)
ubuntu_gcc_no_sse2 74.74% <100.00%> (ø)
ubuntu_gcc_no_sse4 72.67% <100.00%> (ø)
ubuntu_gcc_o3 72.88% <100.00%> (ø)
ubuntu_gcc_osb 75.92% <100.00%> (ø)
ubuntu_gcc_pigz 35.26% <ø> (ø)
ubuntu_gcc_pigz_aarch64 37.04% <ø> (-0.07%) ⬇️
ubuntu_gcc_ppc 73.25% <100.00%> (ø)
ubuntu_gcc_ppc64 76.66% <100.00%> (ø)
ubuntu_gcc_ppc64le 75.14% <100.00%> (ø)
ubuntu_gcc_ppc_no_power8 75.94% <100.00%> (ø)
ubuntu_gcc_s390x 78.03% <100.00%> (-0.03%) ⬇️
ubuntu_gcc_sparc64 77.20% <100.00%> (ø)
ubuntu_gcc_sprefix 73.35% <100.00%> (ø)
win64_gcc ∅ <ø> (∅)
win64_gcc_compat_no_opt ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crc32_comb.c 78.72% <100.00%> (-3.50%) ⬇️
trees.c 96.17% <0.00%> (-0.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70f608c...b19c7d1. Read the comment docs.

@nmoinvaz nmoinvaz added Compatibility API/ABI Compatibility issue API and removed Compatibility API/ABI Compatibility issue labels Dec 20, 2021
@Dead2
Copy link
Member

Dead2 commented Dec 20, 2021

Passes my local testing without warnings, although I don't have any tests testing this function through the exported API.

Dead2 added a commit that referenced this pull request Dec 20, 2021
 - Fix hangs on macOS #1031
 - Fix minideflate write buffers being overwritten #1060
 - Fix deflateBound and compressBound returning too small size estimates #1049 #1071
 - Fix incorrect function declaration warning #1080
 - Fix build problems when building outside of source dir #1049
 - Fix build problems on arm2-7 #1030
 - Fixed some compile warnings #1020 #1036 #1037 #1048
 - Improved posix memalign support #888
 - Improvements to testing #637 #1026 #1032 #1035 #1049 #1051 #1056 #1063 #1067
 - Improvements for integration into other projects #1022 #1042
 - Code style fixes #637 #1040 #1050 #1075
@Dead2 Dead2 mentioned this pull request Dec 20, 2021
Dead2 added a commit that referenced this pull request Dec 20, 2021
 - Fix hangs on macOS #1031
 - Fix minideflate write buffers being overwritten #1060
 - Fix deflateBound and compressBound returning too small size estimates #1049 #1071
 - Fix incorrect function declaration warning #1080
 - Fix build problems when building outside of source dir #1049
 - Fix build problems on arm2-7 #1030
 - Fixed some compile warnings #1020 #1036 #1037 #1048
 - Improved posix memalign support #888
 - Improvements to testing #637 #1026 #1032 #1035 #1049 #1051 #1056 #1063 #1067 #1079
 - Improvements for integration into other projects #1022 #1042
 - Code style fixes #637 #1040 #1050 #1075
@Dead2 Dead2 merged commit 63bc287 into zlib-ng:develop Dec 21, 2021
Dead2 added a commit that referenced this pull request Dec 24, 2021
 - Fix hangs on macOS #1031
 - Fix minideflate write buffers being overwritten #1060
 - Fix deflateBound and compressBound returning too small size estimates #1049 #1071
 - Fix incorrect function declaration warning #1080
 - Fix build problems when building outside of source dir #1049
 - Fix build problems on arm2-7 #1030
 - Fixed some compile warnings #1020 #1036 #1037 #1048
 - Improved posix memalign support #888
 - Improvements to testing #637 #1026 #1032 #1035 #1049 #1051 #1056 #1063 #1067 #1079
 - Improvements for integration into other projects #1022 #1042
 - Code style fixes #637 #1040 #1050 #1075
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants