Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build if -D_FILE_OFFSET_BITS=64 is set manually. #924

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

mtl1979
Copy link
Collaborator

@mtl1979 mtl1979 commented Mar 31, 2021

See #923

We renamed ZLIB_INTERNAL to Z_INTERNAL, but forgot to change the test in zlib.h

@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #924 (8611aa0) into develop (9f78490) will decrease coverage by 4.95%.
The diff coverage is n/a.

❗ Current head 8611aa0 differs from pull request most recent head 9ac4f95. Consider uploading reports for the commit 9ac4f95 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #924      +/-   ##
===========================================
- Coverage    75.49%   70.53%   -4.96%     
===========================================
  Files           74       61      -13     
  Lines         8292     6612    -1680     
  Branches      1369     1137     -232     
===========================================
- Hits          6260     4664    -1596     
+ Misses        1504     1478      -26     
+ Partials       528      470      -58     
Flag Coverage Δ
macos_clang ?
macos_gcc ?
ubuntu_clang ?
ubuntu_clang_debug ?
ubuntu_clang_inflate_allow_invalid_dist ?
ubuntu_clang_inflate_strict ?
ubuntu_clang_mmap ?
ubuntu_clang_msan ?
ubuntu_gcc ?
ubuntu_gcc_aarch64 ?
ubuntu_gcc_aarch64_compat_no_opt ?
ubuntu_gcc_aarch64_no_acle ?
ubuntu_gcc_aarch64_no_neon ?
ubuntu_gcc_armhf ?
ubuntu_gcc_armhf_compat_no_opt ?
ubuntu_gcc_armhf_no_acle ?
ubuntu_gcc_armhf_no_neon ?
ubuntu_gcc_armsf ?
ubuntu_gcc_armsf_compat_no_opt ?
ubuntu_gcc_compat_no_opt ?
ubuntu_gcc_mingw_i686 ?
ubuntu_gcc_mingw_x86_64 ?
ubuntu_gcc_no_avx2 ?
ubuntu_gcc_no_pclmulqdq ?
ubuntu_gcc_no_sse2 ?
ubuntu_gcc_no_sse4 ?
ubuntu_gcc_o3 ?
ubuntu_gcc_osb 70.53% <ø> (ø)
ubuntu_gcc_ppc ?
ubuntu_gcc_ppc64 ?
ubuntu_gcc_ppc64le ?
ubuntu_gcc_s390x ?
ubuntu_gcc_sparc64 ?
win64_gcc ?
win64_gcc_compat_no_opt ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
adler32_p.h 0.00% <0.00%> (-100.00%) ⬇️
arch/x86/chunkset_sse.c 0.00% <0.00%> (-100.00%) ⬇️
arch/x86/adler32_ssse3.c 0.00% <0.00%> (-94.83%) ⬇️
arch/x86/compare258_sse.c 0.00% <0.00%> (-92.00%) ⬇️
arch/x86/slide_sse.c 0.00% <0.00%> (-80.00%) ⬇️
match_tpl.h 0.00% <0.00%> (-71.43%) ⬇️
trees_emit.h 0.00% <0.00%> (-65.83%) ⬇️
trees.c 5.74% <0.00%> (-57.68%) ⬇️
chunkset.c 0.00% <0.00%> (-55.00%) ⬇️
compare258.c 0.00% <0.00%> (-51.62%) ⬇️
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f78490...9ac4f95. Read the comment docs.

@Dead2 Dead2 merged commit b2085a8 into zlib-ng:develop Apr 8, 2021
Dead2 added a commit that referenced this pull request May 8, 2021
- Include porting guide in release packages #917
- Documentation improvements #913 #949
- Added Windows ARM binaries in release packages #916
- Fix crash on ARMv7 #927
- Fix building on FreeBSD #921
- Fix building with musl on aarch64 #936
- Fix ARM float-abi detection #918
- Fix cmake detection of risc-v architectures #942
- Minor buildsystem fixes #922 #924 #933 #938 #950
- Improve zlib-compat build #915 #944
- CI/Test improvements #926 #929 #925 #937 #939 #940
Dead2 added a commit that referenced this pull request May 8, 2021
- Include porting guide in release packages #917
- Documentation improvements #913 #949
- Added Windows ARM binaries in release packages #916
- Fix crash on ARMv7 #927
- Fix building on FreeBSD #921
- Fix building with musl on aarch64 #936
- Fix ARM float-abi detection #918
- Fix cmake detection of risc-v architectures #942
- Minor buildsystem fixes #922 #924 #933 #938 #950
- Improve zlib-compat build #915 #944
- CI/Test improvements #926 #929 #927 #937 #939 #940
@Dead2 Dead2 mentioned this pull request May 8, 2021
Dead2 added a commit that referenced this pull request May 8, 2021
- Include porting guide in release packages #917
- Documentation improvements #913 #949
- Added Windows ARM binaries in release packages #916
- Fix crash on ARMv7 #927
- Fix building on FreeBSD #921
- Fix building with musl on aarch64 #936
- Fix ARM float-abi detection #918
- Fix cmake detection of risc-v architectures #942
- Minor buildsystem fixes #922 #924 #933 #938 #950
- Improve zlib-compat build #915 #944
- CI/Test improvements #926 #929 #927 #937 #939 #940
Dead2 added a commit that referenced this pull request May 9, 2021
- Include porting guide in release packages #917
- Documentation improvements #913 #949
- Added Windows ARM binaries in release packages #916
- Fix crash on ARMv7 #927
- Fix building on FreeBSD #921
- Fix building with musl on aarch64 #936 #952
- Fix ARM float-abi detection #918
- Fix cmake detection of risc-v architectures #942
- Minor buildsystem fixes #922 #924 #933 #938 #950
- Improve zlib-compat build #915 #944
- CI/Test improvements #926 #929 #927 #937 #939 #940
Dead2 added a commit that referenced this pull request May 13, 2021
- Include porting guide in release packages #917
- Documentation improvements #913 #949
- Added Windows ARM binaries in release packages #916
- Fix crash on ARMv7 #927
- Fix building on FreeBSD #921
- Fix building with musl on aarch64 #936 #952
- Fix ARM float-abi detection #918
- Fix cmake detection of risc-v architectures #942
- Minor buildsystem fixes #922 #924 #933 #938 #950
- Improve zlib-compat build #915 #944
- CI/Test improvements #926 #929 #927 #937 #939 #940
gsjaardema pushed a commit to gsjaardema/zlib-ng that referenced this pull request May 13, 2021
- Include porting guide in release packages zlib-ng#917
- Documentation improvements zlib-ng#913 zlib-ng#949
- Added Windows ARM binaries in release packages zlib-ng#916
- Fix crash on ARMv7 zlib-ng#927
- Fix building on FreeBSD zlib-ng#921
- Fix building with musl on aarch64 zlib-ng#936 zlib-ng#952
- Fix ARM float-abi detection zlib-ng#918
- Fix cmake detection of risc-v architectures zlib-ng#942
- Minor buildsystem fixes zlib-ng#922 zlib-ng#924 zlib-ng#933 zlib-ng#938 zlib-ng#950
- Improve zlib-compat build zlib-ng#915 zlib-ng#944
- CI/Test improvements zlib-ng#926 zlib-ng#929 zlib-ng#927 zlib-ng#937 zlib-ng#939 zlib-ng#940
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants