Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements to test-compress cmake script. #940

Merged
merged 4 commits into from
May 3, 2021

Conversation

nmoinvaz
Copy link
Member

PR #939 should be merged first.

This adds writing of file differences using diff tool.
Added status messages to the script.
Write all temporary files to CMake's Testing/Temporary directory.

@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #940 (f0a60fa) into develop (78f07cc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #940   +/-   ##
========================================
  Coverage    77.42%   77.42%           
========================================
  Files           74       74           
  Lines         8307     8307           
  Branches      1374     1373    -1     
========================================
  Hits          6432     6432           
  Misses        1346     1346           
  Partials       529      529           
Flag Coverage Δ
macos_clang 68.55% <ø> (ø)
macos_gcc 67.45% <ø> (ø)
ubuntu_clang 73.41% <ø> (ø)
ubuntu_clang_debug 73.71% <ø> (ø)
ubuntu_clang_inflate_allow_invalid_dist 73.14% <ø> (ø)
ubuntu_clang_inflate_strict 73.40% <ø> (ø)
ubuntu_clang_mmap 73.11% <ø> (ø)
ubuntu_clang_msan 73.41% <ø> (ø)
ubuntu_gcc 72.97% <ø> (ø)
ubuntu_gcc_aarch64 74.26% <ø> (ø)
ubuntu_gcc_aarch64_compat_no_opt 73.78% <ø> (ø)
ubuntu_gcc_aarch64_no_acle 74.07% <ø> (ø)
ubuntu_gcc_aarch64_no_neon 73.82% <ø> (ø)
ubuntu_gcc_armhf 72.20% <ø> (ø)
ubuntu_gcc_armhf_compat_no_opt 73.80% <ø> (ø)
ubuntu_gcc_armhf_no_acle 72.94% <ø> (ø)
ubuntu_gcc_armhf_no_neon 74.94% <ø> (ø)
ubuntu_gcc_armsf 72.17% <ø> (ø)
ubuntu_gcc_armsf_compat_no_opt 73.80% <ø> (ø)
ubuntu_gcc_compat_no_opt 74.88% <ø> (ø)
ubuntu_gcc_mingw_i686 0.00% <ø> (ø)
ubuntu_gcc_mingw_x86_64 0.00% <ø> (ø)
ubuntu_gcc_no_avx2 74.94% <ø> (ø)
ubuntu_gcc_no_pclmulqdq 71.41% <ø> (ø)
ubuntu_gcc_no_sse2 73.90% <ø> (ø)
ubuntu_gcc_no_sse4 71.37% <ø> (ø)
ubuntu_gcc_o3 72.85% <ø> (ø)
ubuntu_gcc_osb 75.83% <ø> (ø)
ubuntu_gcc_ppc 75.25% <ø> (ø)
ubuntu_gcc_ppc64 76.01% <ø> (ø)
ubuntu_gcc_ppc64le 74.77% <ø> (ø)
ubuntu_gcc_s390x 73.64% <ø> (ø)
ubuntu_gcc_sparc64 76.48% <ø> (ø)
win64_gcc 70.39% <ø> (ø)
win64_gcc_compat_no_opt 73.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78f07cc...f0a60fa. Read the comment docs.

Copy link
Member

@Dead2 Dead2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Change filenames used during test to make it more clear what stage they are apart of.
@nmoinvaz nmoinvaz force-pushed the improvements/test-compress-diff branch from c7a74f4 to f0a60fa Compare May 2, 2021 18:05
@nmoinvaz
Copy link
Member Author

nmoinvaz commented May 2, 2021

Rebased.

@nmoinvaz
Copy link
Member Author

nmoinvaz commented May 2, 2021

By the way this is what the output looks like. In this example I just add a null byte unto the end of the file when writing uncompressed. It prints out each command and the input and output files and then the unified diff when comparison doesn't match.

image

@Dead2 Dead2 merged commit 1cdd7df into zlib-ng:develop May 3, 2021
Dead2 added a commit that referenced this pull request May 8, 2021
- Include porting guide in release packages #917
- Documentation improvements #913 #949
- Added Windows ARM binaries in release packages #916
- Fix crash on ARMv7 #927
- Fix building on FreeBSD #921
- Fix building with musl on aarch64 #936
- Fix ARM float-abi detection #918
- Fix cmake detection of risc-v architectures #942
- Minor buildsystem fixes #922 #924 #933 #938 #950
- Improve zlib-compat build #915 #944
- CI/Test improvements #926 #929 #925 #937 #939 #940
Dead2 added a commit that referenced this pull request May 8, 2021
- Include porting guide in release packages #917
- Documentation improvements #913 #949
- Added Windows ARM binaries in release packages #916
- Fix crash on ARMv7 #927
- Fix building on FreeBSD #921
- Fix building with musl on aarch64 #936
- Fix ARM float-abi detection #918
- Fix cmake detection of risc-v architectures #942
- Minor buildsystem fixes #922 #924 #933 #938 #950
- Improve zlib-compat build #915 #944
- CI/Test improvements #926 #929 #927 #937 #939 #940
@Dead2 Dead2 mentioned this pull request May 8, 2021
Dead2 added a commit that referenced this pull request May 8, 2021
- Include porting guide in release packages #917
- Documentation improvements #913 #949
- Added Windows ARM binaries in release packages #916
- Fix crash on ARMv7 #927
- Fix building on FreeBSD #921
- Fix building with musl on aarch64 #936
- Fix ARM float-abi detection #918
- Fix cmake detection of risc-v architectures #942
- Minor buildsystem fixes #922 #924 #933 #938 #950
- Improve zlib-compat build #915 #944
- CI/Test improvements #926 #929 #927 #937 #939 #940
Dead2 added a commit that referenced this pull request May 9, 2021
- Include porting guide in release packages #917
- Documentation improvements #913 #949
- Added Windows ARM binaries in release packages #916
- Fix crash on ARMv7 #927
- Fix building on FreeBSD #921
- Fix building with musl on aarch64 #936 #952
- Fix ARM float-abi detection #918
- Fix cmake detection of risc-v architectures #942
- Minor buildsystem fixes #922 #924 #933 #938 #950
- Improve zlib-compat build #915 #944
- CI/Test improvements #926 #929 #927 #937 #939 #940
Dead2 added a commit that referenced this pull request May 13, 2021
- Include porting guide in release packages #917
- Documentation improvements #913 #949
- Added Windows ARM binaries in release packages #916
- Fix crash on ARMv7 #927
- Fix building on FreeBSD #921
- Fix building with musl on aarch64 #936 #952
- Fix ARM float-abi detection #918
- Fix cmake detection of risc-v architectures #942
- Minor buildsystem fixes #922 #924 #933 #938 #950
- Improve zlib-compat build #915 #944
- CI/Test improvements #926 #929 #927 #937 #939 #940
gsjaardema pushed a commit to gsjaardema/zlib-ng that referenced this pull request May 13, 2021
- Include porting guide in release packages zlib-ng#917
- Documentation improvements zlib-ng#913 zlib-ng#949
- Added Windows ARM binaries in release packages zlib-ng#916
- Fix crash on ARMv7 zlib-ng#927
- Fix building on FreeBSD zlib-ng#921
- Fix building with musl on aarch64 zlib-ng#936 zlib-ng#952
- Fix ARM float-abi detection zlib-ng#918
- Fix cmake detection of risc-v architectures zlib-ng#942
- Minor buildsystem fixes zlib-ng#922 zlib-ng#924 zlib-ng#933 zlib-ng#938 zlib-ng#950
- Improve zlib-compat build zlib-ng#915 zlib-ng#944
- CI/Test improvements zlib-ng#926 zlib-ng#929 zlib-ng#927 zlib-ng#937 zlib-ng#939 zlib-ng#940
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants