Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check for SSSE3 on non-x86 architectures. #950

Merged
merged 1 commit into from
May 8, 2021
Merged

Conversation

Dead2
Copy link
Member

@Dead2 Dead2 commented May 8, 2021

The SSSE3 test had no architecture check like all the others, this adds that.

@Dead2 Dead2 requested review from nmoinvaz and mtl1979 May 8, 2021 13:02
@Dead2 Dead2 added the cleanup Improving maintainability or removing code. label May 8, 2021
@codecov
Copy link

codecov bot commented May 8, 2021

Codecov Report

Merging #950 (dd69f09) into develop (81f1c8a) will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #950      +/-   ##
===========================================
- Coverage    77.07%   76.92%   -0.16%     
===========================================
  Files           74       74              
  Lines         8269     8306      +37     
  Branches      1371     1373       +2     
===========================================
+ Hits          6373     6389      +16     
- Misses        1366     1384      +18     
- Partials       530      533       +3     
Flag Coverage Δ
macos_clang 68.55% <ø> (ø)
macos_gcc 67.45% <ø> (ø)
ubuntu_clang 73.61% <ø> (ø)
ubuntu_clang_debug 73.65% <ø> (ø)
ubuntu_clang_inflate_allow_invalid_dist 73.34% <ø> (ø)
ubuntu_clang_inflate_strict 73.60% <ø> (ø)
ubuntu_clang_mmap 73.31% <ø> (ø)
ubuntu_clang_msan 73.61% <ø> (ø)
ubuntu_gcc 73.00% <ø> (ø)
ubuntu_gcc_aarch64 73.82% <ø> (?)
ubuntu_gcc_aarch64_compat_no_opt 73.32% <ø> (ø)
ubuntu_gcc_aarch64_no_acle 73.64% <ø> (ø)
ubuntu_gcc_aarch64_no_neon 73.38% <ø> (ø)
ubuntu_gcc_armhf 71.76% <ø> (ø)
ubuntu_gcc_armhf_compat_no_opt 73.31% <ø> (ø)
ubuntu_gcc_armhf_no_acle 72.50% <ø> (ø)
ubuntu_gcc_armhf_no_neon 74.49% <ø> (ø)
ubuntu_gcc_armsf 71.74% <ø> (ø)
ubuntu_gcc_armsf_compat_no_opt 73.31% <ø> (ø)
ubuntu_gcc_compat_no_opt 74.42% <ø> (ø)
ubuntu_gcc_mingw_i686 0.00% <ø> (ø)
ubuntu_gcc_mingw_x86_64 0.00% <ø> (ø)
ubuntu_gcc_no_avx2 74.52% <ø> (ø)
ubuntu_gcc_no_pclmulqdq 71.46% <ø> (ø)
ubuntu_gcc_no_sse2 72.54% <ø> (ø)
ubuntu_gcc_no_sse4 71.42% <ø> (ø)
ubuntu_gcc_o3 73.79% <ø> (ø)
ubuntu_gcc_osb 75.98% <ø> (ø)
ubuntu_gcc_ppc 74.80% <ø> (ø)
ubuntu_gcc_ppc64 75.56% <ø> (ø)
ubuntu_gcc_ppc64le 74.32% <ø> (ø)
ubuntu_gcc_s390x 73.23% <ø> (+0.65%) ⬆️
ubuntu_gcc_sparc64 76.03% <ø> (ø)
win64_gcc 70.39% <ø> (ø)
win64_gcc_compat_no_opt 73.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
deflate.h 57.14% <0.00%> (-22.86%) ⬇️
arch/s390/dfltcc_detail.h 0.00% <0.00%> (ø)
compare258.c 51.61% <0.00%> (+1.61%) ⬆️
arch/arm/adler32_neon.c 100.00% <0.00%> (+2.50%) ⬆️
arch/s390/dfltcc_deflate.c 13.66% <0.00%> (+3.02%) ⬆️
arch/s390/dfltcc_inflate.c 15.87% <0.00%> (+3.80%) ⬆️
chunkset.c 55.00% <0.00%> (+10.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81f1c8a...dd69f09. Read the comment docs.

@nmoinvaz
Copy link
Member

nmoinvaz commented May 8, 2021

This is already resolved in #906.

@Dead2
Copy link
Member Author

Dead2 commented May 8, 2021

@nmoinvaz True, but that is a significantly bigger change, and I was hoping to get this simple fix into 2.0.3. What do you think?

@nmoinvaz
Copy link
Member

nmoinvaz commented May 8, 2021

That is ok.

@Dead2 Dead2 merged commit 811ddc9 into develop May 8, 2021
Dead2 added a commit that referenced this pull request May 8, 2021
- Include porting guide in release packages #917
- Documentation improvements #913 #949
- Added Windows ARM binaries in release packages #916
- Fix crash on ARMv7 #927
- Fix building on FreeBSD #921
- Fix building with musl on aarch64 #936
- Fix ARM float-abi detection #918
- Fix cmake detection of risc-v architectures #942
- Minor buildsystem fixes #922 #924 #933 #938 #950
- Improve zlib-compat build #915 #944
- CI/Test improvements #926 #929 #925 #937 #939 #940
Dead2 added a commit that referenced this pull request May 8, 2021
- Include porting guide in release packages #917
- Documentation improvements #913 #949
- Added Windows ARM binaries in release packages #916
- Fix crash on ARMv7 #927
- Fix building on FreeBSD #921
- Fix building with musl on aarch64 #936
- Fix ARM float-abi detection #918
- Fix cmake detection of risc-v architectures #942
- Minor buildsystem fixes #922 #924 #933 #938 #950
- Improve zlib-compat build #915 #944
- CI/Test improvements #926 #929 #927 #937 #939 #940
@Dead2 Dead2 deleted the configure-fix branch May 8, 2021 17:05
@Dead2 Dead2 mentioned this pull request May 8, 2021
Dead2 added a commit that referenced this pull request May 8, 2021
- Include porting guide in release packages #917
- Documentation improvements #913 #949
- Added Windows ARM binaries in release packages #916
- Fix crash on ARMv7 #927
- Fix building on FreeBSD #921
- Fix building with musl on aarch64 #936
- Fix ARM float-abi detection #918
- Fix cmake detection of risc-v architectures #942
- Minor buildsystem fixes #922 #924 #933 #938 #950
- Improve zlib-compat build #915 #944
- CI/Test improvements #926 #929 #927 #937 #939 #940
Dead2 added a commit that referenced this pull request May 9, 2021
- Include porting guide in release packages #917
- Documentation improvements #913 #949
- Added Windows ARM binaries in release packages #916
- Fix crash on ARMv7 #927
- Fix building on FreeBSD #921
- Fix building with musl on aarch64 #936 #952
- Fix ARM float-abi detection #918
- Fix cmake detection of risc-v architectures #942
- Minor buildsystem fixes #922 #924 #933 #938 #950
- Improve zlib-compat build #915 #944
- CI/Test improvements #926 #929 #927 #937 #939 #940
Dead2 added a commit that referenced this pull request May 13, 2021
- Include porting guide in release packages #917
- Documentation improvements #913 #949
- Added Windows ARM binaries in release packages #916
- Fix crash on ARMv7 #927
- Fix building on FreeBSD #921
- Fix building with musl on aarch64 #936 #952
- Fix ARM float-abi detection #918
- Fix cmake detection of risc-v architectures #942
- Minor buildsystem fixes #922 #924 #933 #938 #950
- Improve zlib-compat build #915 #944
- CI/Test improvements #926 #929 #927 #937 #939 #940
gsjaardema pushed a commit to gsjaardema/zlib-ng that referenced this pull request May 13, 2021
- Include porting guide in release packages zlib-ng#917
- Documentation improvements zlib-ng#913 zlib-ng#949
- Added Windows ARM binaries in release packages zlib-ng#916
- Fix crash on ARMv7 zlib-ng#927
- Fix building on FreeBSD zlib-ng#921
- Fix building with musl on aarch64 zlib-ng#936 zlib-ng#952
- Fix ARM float-abi detection zlib-ng#918
- Fix cmake detection of risc-v architectures zlib-ng#942
- Minor buildsystem fixes zlib-ng#922 zlib-ng#924 zlib-ng#933 zlib-ng#938 zlib-ng#950
- Improve zlib-compat build zlib-ng#915 zlib-ng#944
- CI/Test improvements zlib-ng#926 zlib-ng#929 zlib-ng#927 zlib-ng#937 zlib-ng#939 zlib-ng#940
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Improving maintainability or removing code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants