Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect.set accessor edge case #393

Closed
jridgewell opened this issue Apr 7, 2018 · 1 comment
Closed

Reflect.set accessor edge case #393

jridgewell opened this issue Apr 7, 2018 · 1 comment
Labels

Comments

@jridgewell
Copy link

Spotted two more:

const o = Object.defineProperty({}, 'test', {
  get() {}
});
Reflect.set(o.__proto__, 'test', 1, o);
const o = Object.defineProperty({}, 'test', {
  set(v) {}
});
Reflect.set(o.__proto__, 'test', 1, o);

Both should return false, not throw.

zloirock added a commit that referenced this issue Apr 7, 2018
@zloirock
Copy link
Owner

zloirock commented Apr 7, 2018

Thanks, fixed. Seems I should take a look onReflect modules tests because I have not touched it for several years.

@zloirock zloirock closed this as completed Apr 7, 2018
@zloirock zloirock added the bug label Apr 7, 2018
zloirock added a commit that referenced this issue Apr 9, 2018
zloirock added a commit that referenced this issue Apr 9, 2018
zloirock added a commit that referenced this issue Apr 9, 2018
zloirock added a commit that referenced this issue Apr 21, 2018
zloirock added a commit that referenced this issue May 4, 2018
zloirock added a commit that referenced this issue May 5, 2018
zloirock added a commit that referenced this issue May 5, 2018
zloirock added a commit that referenced this issue May 7, 2018
zloirock added a commit that referenced this issue May 7, 2018
zloirock added a commit that referenced this issue May 14, 2018
zloirock added a commit that referenced this issue May 14, 2018
zloirock added a commit that referenced this issue May 18, 2018
zloirock added a commit that referenced this issue May 26, 2018
zloirock added a commit that referenced this issue May 26, 2018
zloirock added a commit that referenced this issue May 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants