Game Freezing

[dpnoyes1]

Game freezes very often. Is a fairly recent problem (last 2 days). Especially when trying to do multiple commands at once or with take offs.

[zlsa]

A few things:

1. When it freezes, could you right-click on the page and select "Inspect Element"; open the console and, if there are any errors, screenshot it (or copy-paste)
2. What hardware do you have?

Unfortunately, "freezes often" is a very generic problem and could be caused by a lot of things.

[dpnoyes1]

Hardware:
64-Bit Windows 8.1
Core i5-4210U
8 gb RAM
NVIDIA GeForce 840M

On Fri Dec 19 2014 at 5:10:36 PM Jon Ross notifications@github.com wrote:

A few things:

1. When it freezes, could you right-click on the page and select
   "Inspect Element"; open the console and, if there are any errors,
   screenshot it (or copy-paste)
2. What hardware do you have?

Unfortunately, "freezes often" is a very generic problem and could be
caused by a lot of things.

—
Reply to this email directly or view it on GitHub
#63 (comment).

[dpnoyes1]

It happens most frequently when giving long commands for planes on the
apron.

eg "w 31l c 10 s 250 f lorah"

On Fri Dec 19 2014 at 5:55:48 PM David Noyes dpnoyes@gmail.com wrote:

Hardware:
64-Bit Windows 8.1
Core i5-4210U
8 gb RAM
NVIDIA GeForce 840M

On Fri Dec 19 2014 at 5:10:36 PM Jon Ross notifications@github.com
wrote:

A few things:

1. When it freezes, could you right-click on the page and select
   "Inspect Element"; open the console and, if there are any errors,
   screenshot it (or copy-paste)
2. What hardware do you have?

Unfortunately, "freezes often" is a very generic problem and could be
caused by a lot of things.

—
Reply to this email directly or view it on GitHub
#63 (comment).

[robbarry]

I've seen this error:
Uncaught TypeError: Cannot read property 'getPosition' of null
Line 931 aircraft.js
var position = runway.getPosition(this.requested.runway);

And this error:
Uncaught TypeError: Cannot read property 'getAngle' of null
aircraft.js:948
this.target.heading = runway.getAngle(this.requested.runway) + Math.PI;

Error seems to occur on KDBG if I order a takeoff from runway 1 and set fix to BOBAK.

[Diastro]

• Seems to be caused by the fact that you direct the plane while it hasn't taken off yet
• Even if you do "takeoff" wait a second or two and then direct the plane to a waypoint but the airplane is still on the runway (altitude read 00) you will get the sim to crash.

@zlsa I can try to look at this but I might need your help.

Thanks

edit: NVM my comment on the runway im tired..

[kurtkraut]

I do confirm the issue with the same symptoms and results.

[Diastro]

Anyone can confirm if my patch fixed the takeoff issue?

[dpnoyes1]

Still frozen when giving take off commands with a fix.

String commands for take off work with heading, climb, speed, just not fix.

w 01l c 10 s 250 heading 270 WORKS

w01l c 10 s 250 f wetor DOES NOT WORK

On Sat Dec 20 2014 at 3:28:12 PM David Albertson notifications@github.com
wrote:

Anyone can confirm if my patch fixed the takeoff issue?

—
Reply to this email directly or view it on GitHub
#63 (comment).

[Diastro]

Have you just tried with the latest version?

I ran exactly this and got no issue :
PLANE_X taxi 1
PLANE_X w01l c 10 s 250 f wetor takeoff

[dpnoyes1]

When I load the bookmark I still see 2.1.7 . Is there a new update at a
different link?

On Sat Dec 20 2014 at 3:49:00 PM David Albertson notifications@github.com
wrote:

Have you juste tried with the latest version?

I ran exactly this and got no issue :
PLANE_X taxi 1
PLANE_X w01l c 10 s 250 f wetor takeoff

—
Reply to this email directly or view it on GitHub
#63 (comment).

[Diastro]

I didn't change the version for this fix. I always test from https://zlsa.github.io/atc/. I can't repro the freezing when trying on this link... Can you try the exact sequence I posted and post any JS error that you can see in the console?

[dpnoyes1]

Sure.

I ran "N359FP w36l c 10 s 250 f muste" and noticed the plane wasn't
taxiing. I repeated the command to taxi, and the program froze.

On Sat Dec 20 2014 at 3:53:35 PM David Albertson notifications@github.com
wrote:

I didn't change the version for this fix. I always test from
https://zlsa.github.io/atc/. I can't repro the freezing when trying on
this link... Can you try the exact sequence I posted and post any JS error
that you can see in the console?

—
Reply to this email directly or view it on GitHub
#63 (comment).

[Diastro]

@dpnoyes1 Oh. Nice. You had the one case I wasn't covering (giving orders while the aircraft is still on the apron). On the sequence I tested (see above) I was taxiing, then giving orders, then taking off.

Can you test now?

[dpnoyes1]

I think I found the issue. It has to do with order of commands.

[Aircraft] c 10 s 250 f romny w10l works

but

[aircraft] w 10l c 10 s 250 f romny does not work

the long commands while on the apron only work if the taxi/wait command is
done last

On Sat Dec 20 2014 at 4:11:33 PM David Albertson notifications@github.com
wrote:

@dpnoyes1 https://github.com/dpnoyes1 Oh. Nice. You had the one case I
wasn't covering (giving orders while the aircraft is still on the apron).
On the sequence I tested (see above) I was taxiing, then giving orders,
then taking off.

Can you test now?

—
Reply to this email directly or view it on GitHub
#63 (comment).

[Diastro]

Can you post the full sequence all the way until after take off?

This is working for me :
[aircraft] w 10l c 10 s 250 f romny
[aircraft] taxi
[aircraft] takeoff

[dpnoyes1]

yes that works for me as well. The game only appears to freeze up if the
taxi command is given BEFORE the fix command

On Sat Dec 20 2014 at 4:20:58 PM David Albertson notifications@github.com
wrote:

Can you post the full sequence all the way until after take off?

This is working for me :

[aircraft] w 10l c 10 s 250 f romny

[aircraft] taxi
[aircraft] takeoff

—
Reply to this email directly or view it on GitHub
#63 (comment).

[Diastro]

This should fix it.

[dpnoyes1]

All fixed. Thanks, loving the game!

On Sat Dec 20 2014 at 4:28:28 PM David Albertson notifications@github.com
wrote:

This should fix it.

—
Reply to this email directly or view it on GitHub
#63 (comment).

[Diastro]

No problem! Thanks for helping out!

Quick tip, if the games crashes again, try to provide exact repro steps and, if possible, open your browser's debugger and give us the exception :).

Thanks again!