Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Parshas #12

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Fix Parshas #12

merged 1 commit into from
Oct 7, 2019

Conversation

zachweix
Copy link
Contributor

@zachweix zachweix commented Oct 7, 2019

In a year like 5779 when Pesach starts on Shabbos, in Galus the Parsha of that week should be Acharei Mos, but it was showing Metzora, fixed that.
Also, the Parshios from Nitzavim to Vezos Habracha were not showing up correctly, that was fixed as well

In a year like 5779 when Pesach starts on Shabbos, in Galus the Parsha of that week should be Acharei Mos, but it was showing Metzora, fixed that.
Also, the Parshios from Nitzavim to Vezos Habracha were not showing up correctly, that was fixed as well
@codecov-io
Copy link

codecov-io commented Oct 7, 2019

Codecov Report

Merging #12 into master will decrease coverage by 0.8%.
The diff coverage is 84.61%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #12      +/-   ##
============================================
- Coverage       100%   99.19%   -0.81%     
- Complexity      232      236       +4     
============================================
  Files            23       23              
  Lines           366      371       +5     
============================================
+ Hits            366      368       +2     
- Misses            0        3       +3
Impacted Files Coverage Δ Complexity Δ
src/Getters/Parsha.php 94.73% <84.61%> (-5.27%) 42 <0> (+4)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9ff50a...25f1141. Read the comment docs.

@zachweix zachweix mentioned this pull request Oct 7, 2019
@yskraus
Copy link

yskraus commented Oct 7, 2019

thank you both issues are fixed

Copy link

@yskraus yskraus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issues are fixed

@tam5 tam5 merged commit 981fe27 into zman-org:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants