Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/fix new module script #127

Merged
merged 2 commits into from
Jun 4, 2018
Merged

Feature/fix new module script #127

merged 2 commits into from
Jun 4, 2018

Conversation

justinbastress
Copy link
Contributor

  • Fix new.sh issues from schema rearrangement
  • Add sample container files
  • Add docker-runner Makefile target to update base image apt repository

How to Test

cd integration_tests && ./new.sh mymodule

@andrewsardone andrewsardone self-requested a review May 31, 2018 13:25
andrewsardone
andrewsardone approved these changes Jun 4, 2018
View reviewed changes
Copy link
Contributor

@andrewsardone andrewsardone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @justinbastress! 🎉 🐳

@andrewsardone andrewsardone merged commit 1f381fb into master Jun 4, 2018
@andrewsardone andrewsardone deleted the feature/fix-new-module-script branch June 4, 2018 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsardone andrewsardone andrewsardone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justinbastress @andrewsardone