Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lints: add more context to w_subject_contains_malformed_arpa_ip. #345

Merged
merged 1 commit into from
Jan 7, 2020

Conversation

cpu
Copy link
Member

@cpu cpu commented Jan 7, 2020

Section 7.1.4.2.1 of the BRs is a good citation for e_subject_contains_reserved_arpa_ip but isn't a great choice for w_subject_contains_malformed_arpa_ip.

When the .arpa address doesn't have enough labels, or can't be parsed as an IP address it's clear that it isn't an internal IP address and so 7.1.4.2.1 isn't a good citation. Section 3.2.2.6 talks about wildcard domains for "registry controlled" zones, and .arpa is one of those (based on BCP49). A wildcard label is one way the .arpa domain wouldn't parse as an IP.

While the larger discussion on how .arpa domains that aren't formatted per RFC 3596 unfolds we can ref 3.2.2.6 and add a bit more context to the lint and description. It isn't perfect, but I think less confusing than ref'ing 7.1.4.2.1, which clearly doesn't apply.

See also #343

@cpu cpu merged commit b7425cb into zmap:master Jan 7, 2020
@cpu cpu deleted the cpu-update-arpa-malformed-refs branch January 7, 2020 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants