AlgorithmIdentifier encoding (Section 7.1.3.1, CAB-Forum BR) #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6c23670.
util: gtld_map autopull updates for 2021-10-21T07:25:20 UTC
christopher-henderson
approved these changes
Oct 24, 2021
sleevi
suggested changes
Oct 26, 2021
v3/lints/cabf_br/lint_subject_public_key_info_improper_algorithm_object_identifier_encoding.go
Outdated
Show resolved
Hide resolved
v3/lints/cabf_br/lint_subject_public_key_info_improper_algorithm_object_identifier_encoding.go
Outdated
Show resolved
Hide resolved
...s/cabf_br/lint_subject_public_key_info_improper_algorithm_object_identifier_encoding_test.go
Outdated
Show resolved
Hide resolved
…hm_object_identifier_encoding.go Co-authored-by: Ryan Sleevi <ryan.sleevi@gmail.com>
|
I briefly wanted to ask whether this pull request is still considered for inclusion? Is there somethig to do on our side? |
sleevi
approved these changes
Jan 15, 2022
There was a problem hiding this comment.
Thanks for the heads up @christopher-henderson - Looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a lint for Section 7.1.3.1 of CAB BR (introduced in v1.7.1 - https://cabforum.org/wp-content/uploads/CA-Browser-Forum-BR-1.7.1.pdf), in particular regarding the encoding of AlgorithmIdentifier for public keys. This lints is related to lint_mp_ecdsa_pub_key_encoding_correct.go. Please consider the lint for inclusion in zlint project.