Add BeforeOrOn and OnOrAfter util functions #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtgag
pushed a commit
to mtgag/zlint
that referenced
this pull request
Nov 1, 2021
christopher-henderson
added a commit
that referenced
this pull request
Jun 13, 2022
… BR) (#643) * lint about the encoding of qcstatements for PSD2 * Revert "lint about the encoding of qcstatements for PSD2" This reverts commit 6c23670. * util: gtld_map autopull updates for 2021-10-21T07:25:20 UTC * added lint for presence of OU in subject * Update v3/lints/cabf_br/lint_subject_contains_organizational_unit_name.go Co-authored-by: Ryan Sleevi <ryan.sleevi@gmail.com> * separated lints to adress two requirements * separated lints to adress two requirements * reverted change proposed by IDE * aligning to #644 * Update v3/util/time.go * Update v3/util/time.go * Update v3/util/time.go * addressed requested changes, removing lint that is implemented in 675 Co-authored-by: mtg <git@mtg.de> Co-authored-by: GitHub <noreply@github.com> Co-authored-by: Ryan Sleevi <ryan.sleevi@gmail.com> Co-authored-by: Christopher Henderson <chris@chenderson.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standard library does not offer functions such as these and reading...
!c.NotBefore.Before(date)-> On or after!c.NotBefore.After(date)-> Before or on...is difficult to keep in your head straight while also comparing it with source requirements.
While I was grepping around for
.Aftercalls I also found some opportunities for datetime cleanups.