Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max length check applies #724

Merged
merged 13 commits into from
Jun 11, 2023

Conversation

mtgag
Copy link
Contributor

@mtgag mtgag commented Jun 9, 2023

Several lints about the maximum length in the value of several components of a subject are always triggered (CheckApplies returns true). It seems more appropriate to check if this component is present in the subject. Lint e_subject_dn_serial_number_max_length for example takes this approach,

(Addendum: Current max length lints check only the subject of a certificate, we could think of new lints checking also the issuer field)

Copy link
Member

@christopher-henderson christopher-henderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

@christopher-henderson christopher-henderson merged commit 59a91a2 into zmap:master Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants