CABF SMIME BR 7.1.2.3.m - Adobe Extensions #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robplee
suggested changes
Nov 9, 2023
| ) | ||
|
|
||
| func init() { | ||
| lint.RegisterLint(&lint.Lint{ |
There was a problem hiding this comment.
So, the lint.Lint type is actually deprecated so this should be creating a lint.CertificateLint which is fairly similar but packages most of the fields that aren't the Lint into a LintMetadata struct. Same comment applies on the other lint too.
v3/util/oid.go
Outdated
| @@ -24,6 +24,8 @@ import ( | |||
|
|
|||
| var ( | |||
| //extension OIDs | |||
| AdobeTimestampOID = asn1.ObjectIdentifier{1, 2, 840, 113583, 1, 1, 9, 1} // Adobe Timestamp x509 extension | |||
There was a problem hiding this comment.
Is the correct formatting "timestamp" or "time-stamp". RFC3161 has it as "Time-stamp" and most online references I can find follow this trend although I've not found any record of Adobe actually defining what their OID should be called.
robplee
approved these changes
Nov 13, 2023
| return &adobeExtensionsLegacyMultipurposeCriticality{} | ||
| } | ||
|
|
||
| // CheckApplies returns true if the certificate's policies assert that it conforms to the multipurpose or legacy policy requirements defined in the SMIME BRs |
There was a problem hiding this comment.
This comment doesn't mention the extra requirement that the certificate must be a subscriber certificate
v3/lints/cabf_smime_br/lint_adobe_extensions_legacy_multipurpose_criticality.go
Outdated
Show resolved
Hide resolved
v3/lints/cabf_smime_br/lint_adobe_extensions_legacy_multipurpose_criticality.go
Outdated
Show resolved
Hide resolved
v3/lints/cabf_smime_br/lint_adobe_extensions_strict_presence.go
Outdated
Show resolved
Hide resolved
…se_criticality.go Co-authored-by: Rob <3725956+robplee@users.noreply.github.com>
Co-authored-by: Rob <3725956+robplee@users.noreply.github.com>
…se_criticality.go Co-authored-by: Rob <3725956+robplee@users.noreply.github.com>
robplee
approved these changes
Nov 15, 2023
christopher-henderson
approved these changes
Nov 19, 2023
42 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding lints to check the presence and criticality of the Adobe x509 Extensions to cover SMIME BR 7.1.2.3.m: