Fix a bug in the check for 7.1.4.2.h - single email address in subject:emailAddress #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ultiple email address subject fields, but dsisallow multiple values in a single email address field fixes a comment on zmap#753
|
@christopher-henderson @zakird can I beg for a review on this and a patch release for this fix? |
zakird
approved these changes
Feb 9, 2024
|
LGTM. @christopher-henderson would you be willing to cut a patch? |
|
@zakird and @cardonator thank you for you patience this past week. I went ahead and skipped the RC and went directly to a 3.6.1 patch release for this. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comments on #753. The Check should not disallow multiple emails in the subject field on a compliant cert, but it should only allow a single value in any individual subject:emailAddress field. This PR fixes that issue.