Add failing test for parsing top-level port in IPv4 records #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a failing test exposing the issue @dadrian and I tried to work around in #9.
The schema in the
test_parses_ipv4_records
test case is loosely adapted from the fullipv4_host
+ztag_ssh_banner
schema from zmap/ztag#68. The fixture JSON is a stripped-down version of the modified ZTag output @dadrian and I used to test zmap/ztag#68 (see https://gist.github.com/cdzombak/aba9071ed41ebb4a6fbba36259457d30).Running tests (
python setup.py test
ornosetests .
) gives the following failure: