Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream shield for reviung34 #1264

Closed
wants to merge 6 commits into from
Closed

Upstream shield for reviung34 #1264

wants to merge 6 commits into from

Conversation

alyx-brett
Copy link

I have this code running on my keyboard right now... the keymap is very quirky and I'm happy for someone to contribute a qwerty map if they like!

Board/Shield Check-list

  • [y] This board/shield is tested working on real hardware
  • [y] Definitions follow the general style of other shields/boards upstream (Reference)
  • [y] .zmk.yml metadata file added
  • [y] Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • [n/a] General consistent formatting of DeviceTree files
  • [y] Keymaps do not use deprecated key defines (Check using the upgrader tool)
  • [n/a] &pro_micro used in favor of &pro_micro_d/a if applicable
  • [n/a] If split, no name added for the right/peripheral half
  • [y] Kconfig.defconfig file correctly wraps all configuration in conditional on the shield symbol
  • [y] .conf file has optional extra features commented out
  • [y] Keyboard/PCB is part of a shipped group buy or is generally available in stock to purchase (OSH/personal projects without general availability should create a zmk-config repo instead)

@Nicell Nicell added enhancement New feature or request shields PRs and issues related to shields labels May 6, 2022
Nicell
Nicell requested changes May 6, 2022
View reviewed changes
app/boards/shields/reviung34/Kconfig.defconfig
@@ -0,0 +1,9 @@
# Copyright (c) 2020 The ZMK Contributors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update all of these to 2022

app/boards/shields/reviung34/Kconfig.defconfig
if SHIELD_REVIUNG34

config ZMK_KEYBOARD_NAME
default "Reviung34"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
default "Reviung34"
default "REVIUNG34"

Creator seems to call it REVIUNG34: https://github.com/gtips/reviung

app/boards/shields/reviung34/Kconfig.shield
@@ -0,0 +1,6 @@

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

app/boards/shields/reviung34/reviung34.keymap
Comment on lines +25 to +31
macros {
ZMK_MACRO(save,
wait-ms = <30>;
tap-ms = <40>;
bindings = <&macro_tap &kp ESC &kp COLON &kp W &kp RET>;
)
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like it's not indented enough when comparing it with the rest of the file.

@alyx-brett alyx-brett closed this by deleting the head repository Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nicell Nicell Nicell requested changes

Assignees
No one assigned
Labels
enhancement New feature or request shields PRs and issues related to shields
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alyx-brett @Nicell