-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(shield): add support of BabyvBle shield #967
base: main
Are you sure you want to change the base?
Conversation
This is a board that is not yet working. removed for pr will work on it soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! I took a quick first glance over the shield and left a few small comments.
These changes have been recommended by dxmh.
Thank you for the feedback I have made the changes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes so quickly! It’s a tidy looking shield. 👍
I have a couple questions for @petejohanson:
- Is
SHIELD_babyvble
ok to be mixed case? I’m not sure if uppercase is required for any technical reason but may be best for consistency with other shields and similar references.
config SHIELD_babyvble |
- Is there a standard/preference for the copyright headers that shields should use, with regards to
The ZMK Contributors
vs named individuals?
* Copyright (c) 2021 The ZMK Contributors |
* Copyright (c) 2021 Pete Johanson, Richard Jones |
Based on pr #978 I have changed the copyright to "The ZMK Contributors" in the documents that have a copyright section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MakerJake01! I’ve suggested just a few minor changes below for consistency with other shields. We’ll then need @petejohanson or @Nicell to review.
Also, I couldn’t quite tell from the link in the metadata file - what is the general availability of this keyboard? Is it open-source, is there a GB planned, or is it stocked somewhere?
Co-authored-by: Dom H <dom@hxy.io>
Co-authored-by: Dom H <dom@hxy.io>
Co-authored-by: Dom H <dom@hxy.io>
@dxmh At the moment I have been selling the extra PCBs that I have bought. I plan on doing something either in-stock, GB, or open-source. It's up in the air and I don't have a site that I update often. Most of my updates are in my discord server so to me it made the most sense to have that as the link. |
I'm starting to think I might need a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After rebasing
on main
, you'll definitely need to install and run pre-commit
to deal with formatting issues (tabs, trailing whitespace, etc). Squashing your commits would also be a very good idea.
label = "KSCAN"; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
label = "KSCAN"; |
This label is now deprecated.
#include <behaviors.dtsi> | ||
#include <dt-bindings/zmk/keys.h> | ||
#include <dt-bindings/zmk/bt.h> | ||
#include <dt-bindings/zmk/mouse.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#include <dt-bindings/zmk/mouse.h> |
...Funnily enough, now that d7d9eed has been merged this would actually build. But you aren't using any mouse behaviors in this keymap, so there isn't much reason to include it.
Hello, this is my first pr and shield for zmk. The board is working on my pcb. I think I have filled out the checklist properly. I used current shield files as the base for the main structure of my files. Eye oh designs has approved the board's name. DFTBA.
Board/Shield Check-list
.zmk.yml
metadata file added&pro_micro
used in favor of&pro_micro_d/a
if applicable.conf
file has optional extra features commented out