A few small additions #65
Conversation
…ible version of FFMpeg.
…e width and height from a codec::Context.
|
So just because I fell into this trap, but https://github.com/meh/rust-ffmpeg is now active again and it seems this version may not be inactive? Might be worth seeing if you can apply your PR to meh's crate if it's not already there (there's some updates this one doesn't have) |
|
wow, seems like a coincidence, but I just took over the maintaining of this ffmpeg-next fork, and reviewing / merging stuff along the way. Not sure what's happening, but I'm currently trying to make ffmpeg-next work with ffmpeg 4.4. Haven't had the chance to review that one yet :) |
|
Ah apologies, I thought this one was now inactive as the last commit was in december and none of my issues and my PR hadn't been responded to. Whereas meh told me he was now working on rust-ffmpeg again and has responded to issues and merged my PRs 😅 . Maybe it's worth talking to someone working with ffmpeg-next to work out what to do going forwards |
|
no worries, it's fresh as of yesterday 😄 |
A while ago I made some extension traits for a personal project. I decided it made sense to add them to the project. There are three main things:
Additionally, in order to get it to build, I added some panic statements to some matches (commit 5306439). Essentially, it makes it that if someone (like me) has a newer version of ffmpeg, they'll still be able to use the library (it'll just panic if they try to do anything that isn't supported).
I only added these in places where it was necessary in order to build. Personally, I think it would be a good idea to add them else where (and I'm more than willing to do it myself), but I thought I should check first.