-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added docker files to build znc for arm arch #3
Conversation
Added dockerfile for arm architure on slim and full directorys Added run command to make docker-entrypoint.sh as executable so we dont get a permissions denied error
@@ -46,7 +46,7 @@ RUN set -x \ | |||
&& cd / && rm -rf /znc-src | |||
|
|||
COPY docker-entrypoint.sh / | |||
|
|||
RUN chmod +x /docker-entrypoint.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's already executable...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When i've tried build the image for arm , i've got some errors relative to this, saying that i dont have permissions to run the script. After i've added this line , the error was fixed .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you accidentally cleared the executable bit from the file in your git checkout before building the image? Or some strange filesystem you use did that for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will try build the image again on my rpi and my laptop to see if this occurs again.
@@ -0,0 +1,52 @@ | |||
FROM arm32v6/alpine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to avoid the exact copy of amd64 Dockerfile. Do you know that in case of such copypaste the copies will always diverge, and various changes will accidentally go to only one copy?
I don't see any arm in https://github.com/docker-library/official-images/tree/master/library |
@DarthGandalf relative to the last point , i dont really understand your question :/ can you explain better ? |
This image is published on docker as "official" at https://hub.docker.com/_/znc/ I see ARM mentioned in https://github.com/docker-library/official-images#architectures-other-than-amd64 but I don't see where it refers to Related: why only arm6, but no arm7 or arm8? |
so @DarthGandalf in your opinion wich is the best approach i can take to try port znc to a arm arch and became a official build ? |
@rubemlrm start with investigating how to make it acceptable as an official build :) My wishlist:
@yosifkit @tianon can you give any advice about official non-amd64 images? Thanks! |
My advice would be to stay away from multiple See docker-library/python#198 (and some of the cross-linked PRs) for our suggested method for adding an appropriate An easy way to do a rough sanity test for the multiarch |
This is fixed, via 7f4f142 and docker-library/official-images#3874 |
Added dockerfile for arm architure on slim and full directorys
Added run command to make docker-entrypoint.sh as executable so we dont get a permissions denied error