Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for comments #14

Closed
2 tasks done
thi8v opened this issue May 20, 2023 · 7 comments
Closed
2 tasks done

Add support for comments #14

thi8v opened this issue May 20, 2023 · 7 comments
Labels
A-Lexer Area: Lexer, in the zom_fe crate C-tracking-issue Category: RFC related tracking issue, that track the implementation of the RFC. enhancement New feature or request
Milestone
0.1.0

Comments

@thi8v
Copy link
Member

thi8v commented May 20, 2023 •
edited
Loading

It's the tracking issue of the RFC-0007

Todo

  • Multi line comments with /* to begin and */ to finish
  • single line comments with //
@thi8v thi8v added enhancement New feature or request A-Lexer Area: Lexer, in the zom_fe crate labels May 20, 2023
thi8v added a commit that referenced this issue May 30, 2023
@thi8v
Rework of the entire lexer, from an Enumerate to a Peekable, add supp…
371c4bb 
…ort for comments #14
@thi8v
Copy link
Member Author

thi8v commented May 30, 2023

Comments are now supported.

@thi8v thi8v closed this as completed May 30, 2023
@thi8v thi8v mentioned this issue May 30, 2023
Open
27 tasks
@thi8v
Copy link
Member Author

thi8v commented Jun 4, 2023 •
edited
Loading

I'm not happy with comments, now, for simplicity, comments starts with # (for simplicity) and end with \n.

  • But I don't like that, instead, I prefer comments that start with (* and end with *).
  • After implementing comments like this, you will have to write the doc for the comments with the number 14 (because that is the problem number)
  • Fix the textmate grammar, to support the new comments
  • Add inline comment with #

@thi8v thi8v reopened this Jun 4, 2023
@thi8v thi8v added this to the 0.1.0 milestone Jun 4, 2023
thi8v added a commit that referenced this issue Jun 4, 2023
@thi8v
Add base doc for comments #14
ab9c87f
@thi8v thi8v mentioned this issue Jun 4, 2023
Closed
21 tasks
thi8v added a commit that referenced this issue Jun 18, 2023
@thi8v
feat: Add support for comments with (* and *) #14
636eecb
thi8v added a commit that referenced this issue Jun 18, 2023
@thi8v
docs: documentation for comments #14
4f4e43a
@thi8v
Copy link
Member Author

thi8v commented Jun 18, 2023

It's done! 636eecb

@thi8v thi8v closed this as completed Jun 18, 2023
@thi8v
Copy link
Member Author

thi8v commented Jul 10, 2023

Add single line comments with #.

@thi8v thi8v reopened this Jul 10, 2023
thi8v added a commit that referenced this issue Jul 10, 2023
@thi8v
feat: implement single line comment #14
44c7b2b
@thi8v
Copy link
Member Author

thi8v commented Jul 15, 2023

Done !

@thi8v thi8v closed this as completed Jul 15, 2023
@thi8v thi8v added the C-tracking-issue Category: RFC related tracking issue, that track the implementation of the RFC. label Jul 15, 2023
@thi8v
Copy link
Member Author

thi8v commented Jul 26, 2023

Finally, reopen the issue to have slashes comment, it will be definitive.

@thi8v thi8v reopened this Jul 26, 2023
@thi8v thi8v mentioned this issue Jul 26, 2023
Merged
@thi8v
Copy link
Member Author

thi8v commented Oct 15, 2023

It's done multi line comments will not be added it's useless, and single line comments are implemented.

@thi8v thi8v closed this as completed Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Lexer Area: Lexer, in the zom_fe crate C-tracking-issue Category: RFC related tracking issue, that track the implementation of the RFC. enhancement New feature or request
Projects
Zom
Status: Done
Milestone
0.1.0
Development

No branches or pull requests
1 participant
@thi8v