Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

Implement database file rotation #23

Closed
zombiezen opened this issue Aug 27, 2016 · 0 comments
Closed

Implement database file rotation #23

zombiezen opened this issue Aug 27, 2016 · 0 comments
Labels
enhancement
Milestone
1.1

Comments

@zombiezen
Copy link
Owner

This is left as a TODO in storage.go, but for database integrity, Sandpass should not be overwriting the file in-place. It should write to another file and os.Rename over the original path. Perhaps we could also implement priority writes, so we could write last-access times in an ad-hoc manner, and then whichever one completely finishes writing saves.
@zombiezen zombiezen added this to the 1.1 milestone Sep 18, 2016
zombiezen added a commit that referenced this issue Dec 13, 2016
@zombiezen
storage: rotate database file
b383fcb 
While I didn't address the cooler idea of having a low-priority writer,
this ensures database integrity.  Either a database write occurs or it
does not: no partial writes happen.

Fixes #23
@zombiezen zombiezen mentioned this issue Dec 13, 2016
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
1 participant
@zombiezen