Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI and port to GitHub actions #287

Closed
schneems opened this issue Aug 1, 2022 · 0 comments · Fixed by #288
Closed

Fix CI and port to GitHub actions #287

schneems opened this issue Aug 1, 2022 · 0 comments · Fixed by #288

Comments

@schneems
Copy link
Member

schneems commented Aug 1, 2022

I am standardizing on GitHub actions for zomboxom for CI as Circle has proven cumbersome. I've ported all the projects except those that use different versions of Rails. Such as:

Eventually, we need also to add tests for Rails 7 as well.

Example CI config: https://github.com/zombocom/maildown/blob/main/.github/workflows/ci.yml

Help wanted

Also, I'm looking for help maintaining this project in the future. I ask anyone interested to please send a PR and mention that you're interested in helping. You can email me if you've previously had a commit merged in this project.

A maintainer will gain commit access and deploy access on rubygems if they don't have it already. A maintainer will be expected to:

  • Update CI to keep tests passing and test new Ruby releases
  • Review, merge, or close PRs
  • Read and respond to issues
  • Any feature or bugfix work that you desire
deepakmahakale added a commit to deepakmahakale/wicked that referenced this issue Aug 2, 2022
deepakmahakale added a commit to deepakmahakale/wicked that referenced this issue Aug 2, 2022
- Add more versions to matrix
- Exclude incompatible versions
- Fix rails 7 later
schneems pushed a commit that referenced this issue Aug 4, 2022
* FIXES #287 - Add GitHub CI
- Add more versions to matrix
- Exclude incompatible versions
- Fix rails 7 later

* Fix the breaking test cases by replacing attr_reader with attr_accessor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant