Use local state for Flipbook Viewer's frame to avoid MST re-renders

[goplayoutside3]

Package

lib-classifier

Linked Issue and/or Talk Post

Partial fix of #5951

❗ This bug is not specific to the flipbook viewer, however it was reported via Daily Minor Planet because that project has an autoplay flipbook, hence exacerbating the Issue linked above. This PR is not a full fix, but of high priority to get Daily Minor Planet data exports back online while I investigate a full fix for all subject viewers.

Describe your changes

• Use local state for frame in FlipbookViewer rather than setFrame and frame from the SubjectViewerStore.
• This is how flipbook worked prior to Change Flipbook and SeparateFrames viewers behavior to not clone drawing marks #5754, so this is a partial reversion of that PR for now.

How to Review

Steps to reproduce the bug are outlined in the linked Issue. Here is a flipbook projects for testing (Daily Minor Planet's workflow might be deactivated):

• https://localhost.zooniverse.org:3000/projects/goplayoutside3/fem-flipbook-viewer/classify/workflow/24066?env=production
• You should be able to play/pause the viewer, select frames via the thumbnail controls, and use the drawing tool for each step.
• metadata.subject_dimensions should have only one record of dimensions upon classification.

Checklist

PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.

General

• Tests are passing locally and on Github
• Documentation is up to date and changelog has been updated if appropriate
• You can yarn panic && yarn bootstrap or docker-compose up --build and FEM works as expected
• FEM works in all major desktop browsers: Firefox, Chrome, Edge, Safari (Use Browserstack account as needed)
• FEM works in a mobile browser

General UX

Example Staging Project: i-fancy-cats

• All pages of a FEM project load: Home Page, Classify Page, and About Pages
• Can submit a classification
• Can sign-in and sign-out

Bug Fix

• The PR creator has listed user actions to use when testing if bug is fixed
• The bug is fixed
• Unit tests are added or updated

[coveralls]

coverage: 80.813% (+0.001%) from 80.812%
when pulling 28b02ae on flipbook-frame-state
into d601d3f on master.

[mcbouslog]

Changes look good, as noted, a partial revert of #5754 .

Confirmed issue with Flipbook viewer, as well as with ImageAndText and MultiFrame viewers.

Confirmed these changes fix issue with Flipbook viewer (classification.metadata.subject_dimensions only includes one item). Viewers that use the subjectViewer store to track frame state will need additional follow-up for fix, as noted.