Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fix: update destroy_links to update updated_at time of resource #4108

Merged
merged 2 commits into from
Feb 9, 2023
Merged

Bug Fix: update destroy_links to update updated_at time of resource #4108

merged 2 commits into from
Feb 9, 2023

Conversation

yuenmichelle1
Copy link
Collaborator

Related to: #4104

Review checklist

  • First, the most important one: is this PR small enough that you can actually review it? Feel free to just reject a branch if the changes are hard to review due to the length of the diff.
  • If there are any migrations, will they the previous version of the app work correctly after they've been run (e.g. the don't remove columns still known about by ActiveRecord).
  • If anything changed with regards to the public API, are those changes also documented in the apiary.apib file?
  • Are all the changes covered by tests? Think about any possible edge cases that might be left untested.

@yuenmichelle1 yuenmichelle1 changed the title update destroy_links to save resource Bug Fix: update destroy_links to update updated_at time of resource Feb 9, 2023
@yuenmichelle1 yuenmichelle1 marked this pull request as ready for review February 9, 2023 21:04
camallen
camallen approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@camallen camallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

lib/json_api_controller/updatable_resource.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added the approved Approved pull request label Feb 9, 2023
@yuenmichelle1 @camallen
Update lib/json_api_controller/updatable_resource.rb
3d36bc4 
Co-authored-by: Campbell Allen <campbell.allen@gmail.com>
@yuenmichelle1 yuenmichelle1 merged commit 3edf62a into master Feb 9, 2023
@yuenmichelle1 yuenmichelle1 deleted the Bug-fix--caching-on-get-request-returns-unlinked-subject-set branch February 9, 2023 23:24
@yuenmichelle1 yuenmichelle1 mentioned this pull request Feb 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camallen camallen camallen approved these changes

@zwolf zwolf Awaiting requested review from zwolf

Assignees
No one assigned
Labels
approved Approved pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuenmichelle1 @camallen