Fix setting _p_changed for small pure-Python BTrees. #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on zopefoundation/zc.zodbdgc#1, we found a bug in the pure-Python BTree implementation. An
elif
that should have been its ownif
prevented the second and subsequent additions to a BTree from setting the_p_changed
flag, right up until the first bucket needed to split.This can cause data-loss for small BTrees.
This PR adds a test case and should fix the issue (the comment is copied from the C implementation).