Proposed fix for issue #4 #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not actually needed at setup time- it is only needed in install_requires. When in setup_requires, this breaks configurations that use local repositories like Artifactory. There are no clean workarounds that I have been able to find. I tested the installer by just removing setup_requires and it works fine. I don't understand why it would need to be there in the first place. Maybe it was a mistake?
|
@agreene5 |
|
ah, my mistake. I just removed the line and it seemed to work fine via python setup.py install. Perhaps I missed something (seems likely) I found a few workarounds via pydistutils.cfg but they were one off / hack type solutions. I guess this PR can be closed and I'll go back to the drawing board. If you have any ideas on how I can cleanly work around this, comment in the issue I entered. If you don't think there's anything that can on the BTrees side, you can close the issue as well. I just can't imagine there not being a way to do this cleanly..hrmm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed setup_requires = ['persistent']
The issue: #48
Since the persistent module is not actually needed at setup time- it is only needed in install_requires, where it is already specified.
When it is present in setup_requires, it breaks configurations that use local repositories
like Artifactory. There are no clean workarounds that I have been able to find.
Since the persistent module is not actually needed at setup time- it is only needed in install_requires, where it is already specified.
When it is present in setup_requires, it breaks configurations that use local repositories
like Artifactory. There are no clean workarounds that I have been able to find.
I tested this and it works fine. Perhaps this was done by mistake?
I'd appreciate if this could be merged into a 4.3.0a or 4.3.1 release on PyPi so I can actually benefit from this being fixed. As of now I am left with clunky workarounds and can't use requirements.txt
I tested this and it works fine. Perhaps this was done by mistake?
I'd appreciate if this could be merged into a 4.3.0a or 4.3.1 release on PyPi so I can actually benefit from this being fixed. As of now I am left with clunky workarounds and can't use requirements.txt