-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix base getattro #11
Conversation
Use as much API from python as possible (even if its declared private). Its better than copy&paste, which breaks if the internal implementation of python changes.
I added a commit which fixes the python version too. |
I can confirm that this fixes failures in the Zope2 tests when using an |
I've looked at this and it looks good to me. The customized |
FYI related to this change: in upgrading an existing Plone add-on to work with Plone 5.1b4 (which incorporates ExtensionClass 4.3.0), I had to change wrapping level used for ComputedAttribute (via a decorator on a class method) from |
Explanation why this pull request is needed can be found here: #7 (comment)
For further discussion lets use this pull request.
I split the change to several commits, so its more obvious what belongs to the python3 port or to our extension.
I also wrote a unittest which worked with the C-Extension of ExtenionClass 4.1.2
This test fails now with pypy. So it looks like the python only version suffers the same problem.