Fix Issue 18: Port scripts to entry points so they can be tested. #21
Conversation
Port to Python 3. Document it.
Port to Python 3. Note that this doesn't do much validation of whether the output makes any sense (in multkey defaults, it doesn't), just that it runs. I'll work on making sense in other PRs if I keep going down the direction of using this to produce a sphinx extension.
|
|
||
|
|
||
| @contextlib.contextmanager | ||
| def stdout_replaced(buf): |
There was a problem hiding this comment.
Why define this here instead of using test.test_support.captured_stdout?
Of course, that's test.support.captured_stdout in Python 3.
--sigh--
There was a problem hiding this comment.
That's one good reason :)
Another is that I know that some Python installations installed by (Linux) package managers don't include some or all of the test package by default (you have to install an additional package); I'm never sure of exactly what may be installed by default, so I try to avoid using it.
There was a problem hiding this comment.
Egads, still???? Silly distributors.
There was a problem hiding this comment.
Yeah, gevent has run into that on numerous occasions because it uses it extensively.
Of course, that module is also explicitly documented as not being a public module and its use is discouraged. So they can make a case for it.
There was a problem hiding this comment.
Imagine hiding something like that in the documentation. I guess those of us who've been around long enough should know to check for that rather than relying on memory.
Ensure test coverage.
Tests for schema2html doesn't do much validation of whether the output makes
any sense (in multkey defaults, for example, it doesn't), just that it runs. I'll
work on making sense in other PRs if I keep going down the direction
of using this to produce a sphinx extension.
Port them to Python 3.
Add documentation.