-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'msgpack-python' egg was renamed 'msgpack' #115
Conversation
Should I retry the failed Python 3.6 tests to see if they're non-deterministic failures? Or is anyone planning to analyze the failure and would rather I didn't destroy the current logs? (I don't think Travis can let you see the logs of jobs that you've retried. If I'm mistaken, I'd love to hear a correction!) |
@jmuchemb Could you please rebase your PR onto master, as it has now successfully running tests again. |
b597acb
to
eaa85c8
Compare
Oh so many failures. We could first require v0.5.6, since the regressions seem to be caused by v0.6. I have no time to work on ZEO code. |
As suggested by @jmuchemb
Using a |
If the failures are simple and the fixes obvious, I think it'd be fine to fix them here while also updating the pin. However, from glancing at the log, neither the failures nor the fixes look simple (to me). In that case, it seems reasonable to merge this simple PR, so that master is working/releasable, and defer the version update to a later PR (so long as there's an issuer so we don't forget). |
I created #122 for the update to a current |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's only a test dependency, so we could probably get away without a change note. On the other hand, it would be good to record somewhere public that (until #122 lands) using the msgpack support requires such-and-such versions of such-and-such dependencies. Changelog lines are cheap, so I would vote for one. But it doesn't seem like a big deal to me.
https://github.com/msgpack/msgpack-python/#very-important-notes-for-existing-users