-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise section "Zope Security" #546
Conversation
- improve formatting - add links for further information about Acquisition - fix references to other chapters modified: docs/zdgbook/ObjectPublishing.rst
I have to admit, this is one of the first section which I revise, which I am not able to follow / understand completely. Especially the first half sentence. Like, of course we use Zope - its the application server. I do not get the difference between "using Zope" vs "own module". Also, I am unsure whether the "Explicit or Implicit" is necessary is correct. For example, in the legacy code base, which I maintain, I got a class, which only inherits from "OFS.Folder.Folder". Having a look at the mro:
|
Originally the ZPublisher was thought of as a generic publisher that could publish not just Zope, but other modules as well. IMHO that whole half sentence can go away. Instead of
I have never used the mro to determine subclasses/mixins, so I can't say whether that is a suitable approach at all. Instead, look at the source, Luke! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After that one replacement it's ready for merging.
The maybe once true distinction between using Zope vs publishing "own modules" with ZPublisher no longer is valid. Removed it. modified: docs/zdgbook/ObjectPublishing.rst
Once again, thanks a lot for taking your time to review my changes and the hint about “I’m just a simple man trying to make my way in the universe.” — Jango Fett |
@dataflake Would you mind to approving the pull request? :-) |
Oops, had not seen the last commit |
The introductory sentence says it all: "If you are using the Zope framework, this section will be irrelevant to you." Also see discussion about "ZPublisher for Zope vs own module", see #546 (comment) modified: docs/zdgbook/ObjectPublishing.rst
* Drop subsection testing. As there is no information about the mentioned "builtin support" for testing. A link to the testing section is already in the table of contents. modified: docs/zdgbook/ObjectPublishing.rst * Drop subsection "Publishable Module". The introductory sentence says it all: "If you are using the Zope framework, this section will be irrelevant to you." Also see discussion about "ZPublisher for Zope vs own module", see #546 (comment) modified: docs/zdgbook/ObjectPublishing.rst * Delete introductionary paragraph. As it relates to the now deleted previous subsection. modified: docs/zdgbook/ObjectPublishing.rst
Help is highly appreciated especially on the documentation which was not updated in years. |
modified: docs/zdgbook/ObjectPublishing.rst