Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add is_roman_numeral func #14

Closed

Conversation

AndrewBasem1
Copy link

Additions

Adding is_roman_numeral function to roman.py file

Why?

This is a helpful function that can be used to check if an input string is a valid roman numeral or not ^_^

@AndrewBasem1
Copy link
Author

I realize this still needs to accomdate the CLI args, just pushing the simplest commit to check if you are open to PRs or not

@dataflake
Copy link
Member

This project is open to PRs, but there's a few issues:

@AndrewBasem1
Copy link
Author

@dataflake thank you for reviewing my PR, Please check the following changes:

  1. fixed linting errors → please rerun the checks again
  2. Added changes to Changes.txt → please review the edit to that file

regarding the unit tests, can you offer some assist on how to start on those? haven't done them before ^_^
I'll sign the agreement later before merging as I don't have access to a printer right now

Thank you

@dataflake
Copy link
Member

@AndrewBasem1 The tests will run automatically whenever you make a push. The linting tests are still failing.

You can add test methods to the test class TestRoman in the tests.py module. The existing tests should make it clear how you call the method or function you want to test with various argument values and then test the return value with the different assert methods.

@icemac
Copy link
Member

icemac commented Jul 10, 2023

Are there any news for this PR otherwise I'd like to close it if there is no interest or steam to complete it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants