Merge pull request #37 from zestsoftware/fredvd-orderedselect-ie11

Change javascript for updating ordered select widget hidden structure
zopefoundation · Feb 1, 2016 · b5a2d0e · b5a2d0e
2 parents 53d9d7b + d3fcb51
commit b5a2d0e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 11 deletions.
diff --git a/CHANGES.txt b/CHANGES.txt
@@ -5,6 +5,11 @@ CHANGES
 3.2.9 (unreleased)
 ------------------
 
+- Change javascript for updating ordered select widget hidden structure so it
+  works again on IE11 and doesn't send back an empty list that deletes all
+  selections on save. Fixes https://github.com/zopefoundation/z3c.form/issues/23
+  [fredvd]
+
 - Started on Dutch translations.
   [maurits]
 

diff --git a/src/z3c/form/browser/orderedselect_input.js b/src/z3c/form/browser/orderedselect_input.js
@@ -108,17 +108,9 @@ function copyDataForSubmit(name)
     {
     // create virtual node with suitable attributes
     var newNode = document.createElement("input");
-    var newAttr = document.createAttribute("name");
-    newAttr.nodeValue = name.replace(/-/g, '.')+':list';
-    newNode.setAttributeNode(newAttr);
-
-    newAttr = document.createAttribute("type");
-    newAttr.nodeValue = "hidden";
-    newNode.setAttributeNode(newAttr);
-
-    newAttr = document.createAttribute("value");
-    newAttr.nodeValue = toSel.options[i].value;
-    newNode.setAttributeNode(newAttr);
+    newNode.setAttribute("name", name.replace(/-/g, '.')+':list');
+    newNode.setAttribute("type", "hidden");
+    newNode.setAttribute("value",toSel.options[i].value );
 
     // actually append virtual node to DOM tree
     toDataContainer.appendChild(newNode);