Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide IRelationBrokenEvent to be able to distinguish the event #7

Closed
wants to merge 3 commits into from

Conversation

vangheem
Copy link
Member

No description provided.

@icemac
Copy link
Member

icemac commented Mar 6, 2017

@vangheem I fixed the Travis tests on master, could you please rebase your PR?

@vangheem vangheem closed this Jun 27, 2017
@icemac
Copy link
Member

icemac commented Jul 20, 2017

Huh? Was closing this PR intensional?

@vangheem vangheem reopened this Nov 19, 2018
Copy link
Member

@mgedmin mgedmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if you fix the ReST mistake.

CHANGES.rst Outdated Show resolved Hide resolved
src/z3c/relationfield/interfaces.py Show resolved Hide resolved
@icemac
Copy link
Member

icemac commented Nov 21, 2018

I think this PR should be merged after #12 as that branch was used for a release. It should be merged to master before anything else.

@icemac
Copy link
Member

icemac commented Nov 22, 2018

@vangheem After I merged #12 now, could you please rebase your PR?

@icemac
Copy link
Member

icemac commented Mar 1, 2019

@vangheem Is this PR still valid?

@vangheem
Copy link
Member Author

Closing this for #18

@vangheem vangheem closed this Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants