-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config with pure python #3
Conversation
Also, do not generate `doc.txt` any more. We have a README.txt, that is enough. modified: setup.py modified: src/zc/zodbrecipes/__init__.py modified: src/zc/zodbrecipes/tests.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some changes I'd like to request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except the minor changes, it looks good.
modified: src/zc/zodbrecipes/tests.py
modified: tox.ini
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes would be good
modified: src/zc/zodbrecipes/tests.py
modified: setup.py
modified: src/zc/zodbrecipes/__init__.py
Thanks to mgedmin for pointing me to https://github.com/buildout/buildout/blob/0185dc6a87f417160378547c776fb6da0c016e88/src/zc/buildout/testing.txt#L123-L152 modified: .meta.cfg modified: tox.ini
Huh, coverage works on my machine, but fails on Travis. Any hints for me? Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The coverage problem should be simple to fix.
modified: tox.ini
No description provided.