Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config with pure python #3

Merged
merged 12 commits into from
May 16, 2020
Merged

Config with pure python #3

merged 12 commits into from
May 16, 2020

Conversation

jugmac00
Copy link
Member

No description provided.

@jugmac00
Configuring for pure-python
5682afe
@jugmac00
Fix linting errors
3454cbb 
Also, do not generate `doc.txt` any more. We have a README.txt, that is
enough.

modified:   setup.py
modified:   src/zc/zodbrecipes/__init__.py
modified:   src/zc/zodbrecipes/tests.py
@jugmac00 jugmac00 mentioned this pull request May 15, 2020
Closed
icemac
icemac requested changes May 15, 2020
View reviewed changes
Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes I'd like to request.

src/zc/zodbrecipes/tests.py Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
sallner
sallner approved these changes May 15, 2020
View reviewed changes
Copy link
Member

@sallner sallner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the minor changes, it looks good.

.meta.cfg Outdated Show resolved Hide resolved
src/zc/zodbrecipes/tests.py Outdated Show resolved Hide resolved
@jugmac00 jugmac00 requested a review from icemac May 15, 2020 15:28
mgedmin
mgedmin requested changes May 15, 2020
View reviewed changes
Copy link
Member

@mgedmin mgedmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes would be good

setup.py Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
src/zc/zodbrecipes/__init__.py Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
@jugmac00
Remove unused import
bf345c7 
modified:   src/zc/zodbrecipes/tests.py
@jugmac00
Update url in setup.py
eeeb835 
modified:   setup.py
@jugmac00
Do not catch bare exception
619675d 
modified:   src/zc/zodbrecipes/__init__.py
@jugmac00
Fix coverage
791d106 
Thanks to mgedmin for pointing me to
https://github.com/buildout/buildout/blob/0185dc6a87f417160378547c776fb6da0c016e88/src/zc/buildout/testing.txt#L123-L152

modified:   .meta.cfg
modified:   tox.ini
@jugmac00
Copy link
Member Author

Huh, coverage works on my machine, but fails on Travis.

Any hints for me?

Thank you.

@jugmac00 jugmac00 requested a review from mgedmin May 15, 2020 21:48
mgedmin
mgedmin approved these changes May 16, 2020
View reviewed changes
Copy link
Member

@mgedmin mgedmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The coverage problem should be simple to fix.

tox.ini Outdated Show resolved Hide resolved
@jugmac00 jugmac00 mentioned this pull request May 16, 2020
Open
@jugmac00
Fix coverage on Travis
f298afa 
modified:   tox.ini
@jugmac00 jugmac00 merged commit 43ea38a into master May 16, 2020
@jugmac00 jugmac00 deleted the config-with-pure-python branch May 16, 2020 08:36
@jugmac00
Copy link
Member Author

Now, this was a difficult birth.

Thanks a lot @mgedmin @icemac and @sallner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgedmin mgedmin mgedmin approved these changes

@sallner sallner sallner approved these changes

@icemac icemac Awaiting requested review from icemac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jugmac00 @mgedmin @icemac @sallner