Skip to content

Commit

Permalink
Assorted minor build cleanups
Browse files Browse the repository at this point in the history
The -q in `setup.py test -q` does nothing.

The -q in `setup.py -q test` makes the build quiet before running the
tests.

The testing extra was a weird thing, not used anywhere.  Also nose is
abandoned upstream.

Depending on . in a tox.ini makes no sense, since tox always installs
the current package.  I can only assume it was .[test] or something in
the past and wasn't cleaned up cleanly when the test extra became empty.
  • Loading branch information
mgedmin committed Nov 8, 2019
1 parent 22309cb commit 6ad32b9
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 4 deletions.
2 changes: 1 addition & 1 deletion appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ build_script:
- python -W ignore setup.py -q bdist_wheel

test_script:
- python setup.py test -q
- python setup.py -q test

artifacts:
- path: 'dist\*.whl'
Expand Down
1 change: 0 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@
ext_modules=ext_modules,
extras_require={
'test': [],
'testing': ['nose', 'coverage'],
},
test_suite='zodbpickle.tests.test_pickle.test_suite',
install_requires=[
Expand Down
3 changes: 1 addition & 2 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,8 @@ envlist = py27,py35,py36,py37,py38,pypy,pypy3,coverage-report
[testenv]
usedevelop = True
commands =
coverage run setup.py test -q
coverage run setup.py -q test
deps =
.
coverage
setenv =
COVERAGE_FILE=.coverage.{envname}
Expand Down

0 comments on commit 6ad32b9

Please sign in to comment.