Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'verifyObject' for class objects with staticmethods on Python 3. #127

Merged
merged 2 commits into from
Oct 23, 2018
Merged

Fix 'verifyObject' for class objects with staticmethods on Python 3. #127

merged 2 commits into from
Oct 23, 2018

Conversation

jamadden
Copy link
Member

Fixes #126

rouge8
rouge8 approved these changes Oct 23, 2018
View reviewed changes
Copy link

@rouge8 rouge8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that this fixes #126 for me 🎉

src/zope/interface/tests/test_verify.py Outdated
class IFoo(Interface):

def bar(a, b):
pass
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think to make coverage happy you can change this to raise NotImplementedError()

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, usually I'm pretty good about that kind of thing. Thanks!

@jamadden jamadden merged commit 706ced7 into master Oct 23, 2018
@jamadden jamadden deleted the issue126 branch October 23, 2018 20:16
@jamadden
Copy link
Member Author

Thanks! 4.6.0 has been released to PyPI.

@rouge8
Copy link

rouge8 commented Oct 23, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rouge8 rouge8 rouge8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamadden @rouge8