Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the OpenAI Gym dependency version and Added FAQ 3. #11

Merged
merged 1 commit into from
Jan 29, 2019

Conversation

KimSangYeon-DGU
Copy link
Contributor

Hi @zoq. This is related to #10 .
I guess the OpenAI gym's interface has been changed.

14:11:03.536 [error] GenServer #PID<0.160.0> terminating
** (stop) {:python, :"builtins.ImportError", 'cannot import name \'Monitor\'', {:"$erlport.opaque", :python, <<128, 2, 99, 116, 114, 97, 99, 101, 98, 97, 99, 107, 10, 83, 116, 97, 99, 107, 83, 117, 109, 109, 97, 114, 121, 10, 113, 0, 41, 129, 113, 1, 40, 99, 116, 114, 97, 99, 101, 98, 97, 99, 107, 10, 70, ...>>}}
    /home/sy0814k/Desktop/KSY/gym_tcp_api/deps/erlport/src/erlport.erl:234: :erlport.call/3
    (gym_tcp_api) lib/worker.ex:25: GymTcpApi.Worker.handle_call/3
    (stdlib) gen_server.erl:636: :gen_server.try_handle_call/4
    (stdlib) gen_server.erl:665: :gen_server.handle_msg/6
    (stdlib) proc_lib.erl:247: :proc_lib.init_p_do_apply/3
Last message (from #PID<0.167.0>): {"{\"env\":{\"name\": \"CartPole-v0\"}}\r\n", #PID<0.166.0>}
State: #PID<0.161.0>
Client #PID<0.167.0> is alive
    (stdlib) gen.erl:169: :gen.do_call/4
    (stdlib) gen_server.erl:202: :gen_server.call/2
    (gym_tcp_api) lib/worker.ex:40: GymTcpApi.Worker.process/

This issue can be avoided by downgrading Gym's version. So, I updated our README.md and added FAQ 3 about how to downgrade Gym's version.

Copy link
Owner

@zoq zoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think we should still see if we can update the code so that it works with the latest OpenAI gym interface, but this is definitely a good temporary fix.

@zoq zoq merged commit 4b5f067 into zoq:master Jan 29, 2019
@KimSangYeon-DGU
Copy link
Contributor Author

@zoq
Agreed!!, I'll push this to my work queue. :)

@zoq
Copy link
Owner

zoq commented Jan 31, 2019

Sounds great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants