-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
@@ -7,7 +7,8 @@ defmodule FranklinWeb.Endpoint do | |||
@session_options [ | |||
store: :cookie, | |||
key: "_franklin_key", | |||
signing_salt: "XYGfSGw+" | |||
signing_salt: "XYGfSGw+", | |||
same_site: "Lax" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: Lookup what this means.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was added in phoenixframework/phoenix#4677 and related to: phoenixframework/phoenix#4877
@@ -44,16 +43,18 @@ defmodule Franklin.MixProject do | |||
[ | |||
# Core Phoenix Deps | |||
{:ecto_sql, "~> 3.6"}, | |||
{:esbuild, "~> 0.4", runtime: Mix.env() == :dev}, | |||
{:esbuild, "~> 0.5", runtime: Mix.env() == :dev}, | |||
{:finch, "~> 0.14"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a new addition which is easy to miss. Seems like the preferred networking library for the default Swoosh integration. I'm not doing email currently, but I pulled it in to match the generator.
When adding it, I hit a bit of a dependency conflict with castore
. I believe I resolved it by first unlocking castore
(with mix deps.unlock castore
) and then adding finch
and running the normal deps.get
.
Fixes #155
PR code walk: https://www.youtube.com/watch?v=RYOc2nL-qfY
How I approached the upgrade:
phx_new
1.7.1 installer (this changes the generated project to include the hero icons) and generating a fresh project with the same name of your current. There are some new files you can wholesale copy in to your project.Notes
{:phoenix_view, "~> 2.0"}
to your dependency list.