Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Django 4 support #398

Closed
dyve opened this issue Dec 26, 2021 · 1 comment · Fixed by #447
Closed

Django 4 support #398

dyve opened this issue Dec 26, 2021 · 1 comment · Fixed by #447

Comments

@dyve
Copy link
Member

dyve commented Dec 26, 2021

The tests show incompatibility with Django 4. Fixing this seems to require a refactor of the renderer. This work has already been done for django-bootstrap5, so we might backport that. However, I'm not sure it's worth the time investment. Until then, declare Django 4 officially unsupported.
@dyve dyve mentioned this issue Dec 26, 2021
Merged
@se-bastiaan se-bastiaan mentioned this issue Dec 27, 2021
Merged
1 task
@dyve
Copy link
Member Author

dyve commented Feb 16, 2022 •
edited
Loading

Looking at this again, external effort, information, PR also welcome.

@dyve dyve mentioned this issue Mar 7, 2022
Merged
@dyve dyve closed this as completed in #447 Mar 7, 2022
dyve added a commit that referenced this issue Mar 7, 2022
@dyve
Support Django 4 (#447)
7ee7b1b 
Add support for Django 4. Fixes #398.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support Django 4 zostera/django-bootstrap4
1 participant
@dyve